-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[Bug Fix] Support casting lightweight float formats to complex types #75929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
|
/re-run all-failed |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #75929 +/- ##
==========================================
Coverage ? 0.00%
==========================================
Files ? 1
Lines ? 16
Branches ? 0
==========================================
Hits ? 0
Misses ? 16
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/re-run all-failed |
|
/re-run all-failed |
ba35212 to
6aae326
Compare
|
/re-run all-failed |
|
/re-run all-failed |
|
/re-run all-failed |
|
单侧覆盖率不够,需要补充单侧。#75929 (comment) |
明白了,之前强推的含单测的提交 6aae326 流水线没过,可能是因为我之前有个对cast_impl.h修改的pr #75930 没有合入,导致单测没有生效,我这次再试试 |
|
/re-run all-failed |
|
#76185 已经解决该问题 |
PR Category
Environment Adaptation
PR Types
Bug fixes
Description
CastDataTypeFunctor对float8_e4m3fn、float8_e5m2、bfloat16、float16到complex64/complex128的专门实现;这些组合之前没有合法的static_cast,会在模版实例化时报错或导致转换缺失。编译时的错误日志如下: