Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to add a forced load balancing mode for the MoE router by introducing a fake_balanced_routing method that provides deterministic routing distribution. However, the implementation has critical bugs that will break the code.
Changes:
- Added
fake_balanced_routingmethod to provide deterministic balanced expert routing - Commented out router weight initialization and related parameters
- Modified gradient computation in fused all-to-all backward pass
- Added conditional dispatch logic and commented out auxiliary loss computation
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 11 comments.
| File | Description |
|---|---|
| src/paddlefleet/transformer/moe/moe_router.py | Added fake_balanced_routing method and commented out weight initialization, breaking normal routing mode |
| src/paddlefleet/transformer/moe/moe_layer.py | Added dispatch_overlap method and modified fusion_moe_forward to support new routing path; commented out aux loss |
| src/paddlefleet/transformer/moe/fused_a2a.py | Changed gradient return to None for token probabilities, breaking backpropagation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.