Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade Pingora to 0.8.0 and fix security vulnerabilities discovered by
cargo audit.Security Fixes
BytesMut::reserve(RUSTSEC-2026-0007)htpasswd-verify: Replace with a self-contained htpasswd verification module built onmd-5/sha1/bcrypt, eliminating the vulnerablerust-cryptodependency chain (RUSTSEC-2022-0011 AES miscomputation, RUSTSEC-2022-0004 stack overflow, RUSTSEC-2020-0071 segfault). The new module supports all htpasswd formats: Bcrypt, SHA-1, APR1, and MD5-crypt.rustls-pemfiledirect dependency: Marked unmaintained (RUSTSEC-2025-0134) and not referenced anywhere in source codeAudit Summary
Before: 6 vulnerabilities + 6 warnings → After: 1 vulnerability + 3 warnings (all from upstream pingora transitive dependencies, out of our control)
Type of Change
Checklist
cargo fmtandcargo clippycargo test --all)Testing
Test Configuration:
Test Steps:
cargo check— compiles with no warningscargo test --lib basic_auth— all 18 tests pass (5 new htpasswd module tests + existing plugin tests)cargo audit— vulnerabilities reduced from 6 to 1 (remaining is upstream pingora's transitiveprotobufdependency)Additional Notes
Remaining issues are all from upstream pingora transitive dependencies and require upstream updates to resolve:
protobuf 2.28.0daemonize 0.5.0derivative 2.2.0rustls-pemfile 2.2.0