Fix uses of structured bindings to conform to C++17 standard and appe…#61
Open
neboat wants to merge 1 commit intoParAlg:masterfrom
Open
Fix uses of structured bindings to conform to C++17 standard and appe…#61neboat wants to merge 1 commit intoParAlg:masterfrom
neboat wants to merge 1 commit intoParAlg:masterfrom
Conversation
tomtseng
approved these changes
Jan 24, 2021
Member
tomtseng
left a comment
There was a problem hiding this comment.
sad that this is necessary but i've run into this issue too
i suspect that in a few months time i'll forget what the _sb suffix means and why we bind and reassign variables like this... maybe std::tie is less confusing in that respect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ase Clang. For discussion on this topic, see https://stackoverflow.com/questions/46114214/lambda-implicit-capture-fails-with-variable-declared-from-structured-binding.