Skip to content

Fix infinite loop in ApproximateSetCover at bucket 0 due to unsigned underflow #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alanSquirrelyz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix infinite loop in ApproximateSetCover at bucket 0 due to unsigned underflow #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion benchmarks/ApproximateSetCover/MANISBPT11/ApproximateSetCover.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@ inline parlay::sequence<uintE> SetCover(Graph& G, size_t num_buckets = 512) {

// 3. sets -> elements (count and add to cover if enough elms were won)
const size_t low_threshold =
std::max((size_t)ceil(pow(1.0 + sc::epsilon, cur_bkt - 1)), (size_t)1);
(cur_bkt == 0) ? (size_t)1
: std::max((size_t)ceil(pow(1.0 + sc::epsilon, cur_bkt - 1)), (size_t)1);
auto won_ngh_f = [&](const uintE& u, const uintE& v, const W& wgh) -> bool {
return Elms[v] == perm[u];
};
Expand Down