Skip to content

Conversation

@warriorstar-orion
Copy link
Contributor

What Does This PR Do

This PR breaks up randomverbs.dm (> 1000 loc), and misc_admin_procs.dm (> 900 loc), disseminating the verbs in them into mostly separate files designated by the permissions of the verb.

  • In some cases I grouped up a bunch of verbs into a new module, like ooc_channel_verbs.dm, or took egregiously large verbs and moved them into their own file, like player_panel_verb.dm.
  • In places where a verb allowed multiple perms, I made a judgement call.
  • I haven't touched everything, e.g. USER_VERBs that already existed somewhere in /code/modules/admin/verbs I left alone.
  • Yes, admin_verbs.dm is now nearly 1,000 loc, but at least it's 1,000 lines of actually admin verbs, and not random crap, and makes it easier to see that more organization is necessary.

This isn't perfect but it's much, much better than the current state of things.

Again this is all just moving code around, no code/permission changes.

Why It's Good For The Game

There's no longer multiple files serving as thousand-line dumping grounds for the hundreds of user verbs we have.

Testing

CI.

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

NPFC

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Jan 7, 2026
Copy link
Member

@DGamerL DGamerL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-Status: Awaiting type assignment This PR is waiting for its type to be assigned internally

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants