Open
Conversation
Member
|
I'm not a huge fan of bringing these annotations back, if possible it would be nice to have them in a separate compilation unit that's not included by default. |
coderbot16
requested changes
Jun 6, 2020
Member
coderbot16
left a comment
coderbot16
left a comment
There was a problem hiding this comment.
If we are bringing back @SubscribeEvent, it would make sense to include all of the parameters/arguments too (priority, etc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to preserve forge's magic annotations so that the decompiled bytecode is easier to follow.