🔧 Avoid blocking when reading data from request stream #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GQMai
changed the title
Contributor
|
@GQMai Thanks for the fix. Can you please add a news file for the release notes, e.g. Please note that this example should never be used for production environments. |
Author
Sure. It's done. |
madchutney
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following call can block under certain WSGI servers which implements only PEP 333 not PEP 3333
request.stream.read()It can be avoided by changing it to
request.stream.read(request.content_length or 0)Reference:
https://falcon.readthedocs.io/en/stable/api/request_and_response.html
https://stackoverflow.com/questions/22894078/why-does-environwsgi-input-read-block-even-though-it-is-allowed-by-pep-333?answertab=oldest#tab-top