🔧 Disabled trust for insecure environment #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Lots of projects are dealing with this |
Contributor
|
@ryannowarm Thanks for spotting this, if it goes through CI ok we'll get this in. Can you please add a news file for the release notes, e.g. |
madchutney
changed the title
requests doesn't a bunch of weird things, including reading auth info from your ~/.netrc file. Disable that so our authorization header doesn't get stomped.
ryannowarm
force-pushed
the
dont_trust_environment_settings
branch
from
65474ae to
6f257e1
Compare
Author
|
I've added the news entry |
madchutney
approved these changes
Sep 13, 2019
Contributor
madchutney
left a comment
madchutney
left a comment
There was a problem hiding this comment.
Thanks for adding the news file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requests does a bunch of weird things, including reading auth info from your ~/.netrc file. Disable that so our authorization header doesn't get stomped.