Issue #70: update the README #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
into the block for Perl 5.12 or higher. Actually it is not obvious why Pod::Readme would not work for Perl 5.10.
Assuming the Perl 5.10 is the earliest supported version.
oalders
requested changes
Sep 29, 2024
| - Test::Warnings | ||
|
|
||
| ## Only on Perl 5.10 and later | ||
| ## Only on Perl 5.10 |
There was a problem hiding this comment.
Maybe we could clarify about these. We are pinning to specific versions on 5.10 as those should be the last 5.10 supported versions of those modules. They should also get installed in more recent Perls, but we haven't specified a version requirement. If they're not specifically listed elsewhere, I assume they are pulled in via dependencies or they were at the time when the change was made.
There was a problem hiding this comment.
Yes, I thought the same. I'll verify that these are actually pulled in as dependencies and explicitly list them in the cpanfile. This means that fewer cases must be distinguished in Readme.mk.
There was a problem hiding this comment.
@bschmalhofer any updates on this?
atoomic
force-pushed
the
main
branch
2 times, most recently
from
2ffdcf6 to
1796acf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for #70.
I don't recall why I thought the Perl::Tidy was not included in the Docker image. Looking at the cpanfile I found that both
Perl::TidyandPerl::Criticare in the cpanfile.So I only updated README.md to reflect the current state of affairs. There I assumed that Perl 5.10 is the earliest supported version of Perl.