Skip to content

Making Pharo12 the default baseline #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StevenCostiou merged 20 commits into from
Dec 29, 2024
Merged

Making Pharo12 the default baseline #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
87bc1ad
updating Spec API calls for Debugging Spi in P11
adri09070 Nov 16, 2023
16dc867
updating Morph API calls for Debugging Spy in P11
adri09070 Nov 16, 2023
9dfc2fc
fixing recompilation of `StPlayground class>>#open`
adri09070 Nov 16, 2023
cfd661d
Merge 9dfc2fc6f4b93ea23b09fad32491dc07d6c5bed0
adri09070 Nov 16, 2023
26b2b63
adding CI for P11
adri09070 Nov 16, 2023
2fb6cd3
fixing yaml for P11 CI
adri09070 Nov 16, 2023
70c7f62
fixing a method to fix `DSSpyInstrumenterTest>>#testInstrumentRubEdit…
adri09070 Nov 16, 2023
f9b49c6
fixing Breakpoint API calls for P11
adri09070 Nov 16, 2023
da7e082
fixing tests calling a more basic method with the code from Pharo 9, …
adri09070 Nov 16, 2023
846509f
creating a replacement for `StPlaygroundPage` for test because the me…
adri09070 Nov 16, 2023
6299aa0
fixing InspectorPageSelection instrumentation according to P11 base …
adri09070 Nov 16, 2023
f545ec6
fixing tests by replacing StXXX by StXXXPresenter
adri09070 Nov 23, 2023
b46ec64
forgot to replace StInpector -> StInspectorPresenter in instrumentation
adri09070 Nov 23, 2023
a320a95
fixing test
adri09070 Nov 23, 2023
8bfc386
fixing another inspector instrumentation test
adri09070 Nov 23, 2023
08ed2b7
fixing MetaBrowser instrumentation tests
adri09070 Nov 23, 2023
bf83284
fixing yaml for CI for Pharo 12
adri09070 Nov 23, 2023
d89da48
forgot rewriting StInspector -> >StInspectorPresenter
adri09070 Nov 23, 2023
d6afe71
Merge bf83284c65beb314df336033ecf721ce03338105
adri09070 Nov 23, 2023
c0593bb
Merge branch 'master' into P12
StevenCostiou Dec 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dsspy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
PROJECT_NAME: ${{ matrix.smalltalk }}-DebuggingSpy
strategy:
matrix:
smalltalk: [ Pharo64-9.0 ]
smalltalk: [ Pharo64-12 ]
name: ${{ matrix.smalltalk }}
steps:
- uses: actions/checkout@v2
Expand Down
9 changes: 5 additions & 4 deletions DebuggingSpy-Tests/DSFakeTextEditor.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@ I am a fake text editor that inherits from RubTextEditor.
My purpose is to ease testing of instrumented methods from RubTextEditor without triggering a full behavior of the text editor that is in an incomplete state for the tests.
"
Class {
#name : #DSFakeTextEditor,
#superclass : #RubSmalltalkEditor,
#category : #'DebuggingSpy-Tests'
#name : 'DSFakeTextEditor',
#superclass : 'RubSmalltalkEditor',
#category : 'DebuggingSpy-Tests',
#package : 'DebuggingSpy-Tests'
}

{ #category : #accessing }
{ #category : 'accessing' }
DSFakeTextEditor >> contents: anObject [
]
11 changes: 6 additions & 5 deletions DebuggingSpy-Tests/DSNoDebuggerSelectionStrategy.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,18 @@
I am a debugger opening strategy that eat all debugger opening requests to avoid opening debuggers during testing.
"
Class {
#name : #DSNoDebuggerSelectionStrategy,
#superclass : #OupsDebuggerSelectionStrategy,
#category : #'DebuggingSpy-Tests'
#name : 'DSNoDebuggerSelectionStrategy',
#superclass : 'OupsDebuggerSelectionStrategy',
#category : 'DebuggingSpy-Tests',
#package : 'DebuggingSpy-Tests'
}

{ #category : #iterating }
{ #category : 'iterating' }
DSNoDebuggerSelectionStrategy >> nextDebugger [
^ self
]

{ #category : #debuggers }
{ #category : 'debuggers' }
DSNoDebuggerSelectionStrategy >> openDebuggerForSession: aDebugSession [
^self
]
13 changes: 7 additions & 6 deletions DebuggingSpy-Tests/DSRecordRegistryTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,26 @@
Class {
#name : #DSRecordRegistryTest,
#superclass : #TestCase,
#name : 'DSRecordRegistryTest',
#superclass : 'TestCase',
#instVars : [
'record'
],
#category : #'DebuggingSpy-Tests'
#category : 'DebuggingSpy-Tests',
#package : 'DebuggingSpy-Tests'
}

{ #category : #running }
{ #category : 'running' }
DSRecordRegistryTest >> tearDown [

DSRecordRegistry autoSerialize: nil.
super tearDown
]

{ #category : #tests }
{ #category : 'tests' }
DSRecordRegistryTest >> testAutoSerialize [
self deny: DSRecordRegistry autoSerialize
]

{ #category : #tests }
{ #category : 'tests' }
DSRecordRegistryTest >> testAutoSerializeRecord [
|materializedRecord|
DSSpy logger loggingFileReference ensureDelete.
Expand Down
9 changes: 5 additions & 4 deletions DebuggingSpy-Tests/DSRecordTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
Class {
#name : #DSRecordTest,
#superclass : #TestCase,
#name : 'DSRecordTest',
#superclass : 'TestCase',
#instVars : [
'record'
],
#category : #'DebuggingSpy-Tests'
#category : 'DebuggingSpy-Tests',
#package : 'DebuggingSpy-Tests'
}

{ #category : #tests }
{ #category : 'tests' }
DSRecordTest >> testRecordPrinting [

| str |
Expand Down
39 changes: 20 additions & 19 deletions DebuggingSpy-Tests/DSSTONFileLoggerTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
Class {
#name : #DSSTONFileLoggerTest,
#superclass : #TestCase,
#name : 'DSSTONFileLoggerTest',
#superclass : 'TestCase',
#instVars : [
'logger',
'survey',
'task',
'oldLogger'
],
#category : #'DebuggingSpy-Tests'
#category : 'DebuggingSpy-Tests',
#package : 'DebuggingSpy-Tests'
}

{ #category : #running }
{ #category : 'running' }
DSSTONFileLoggerTest >> setUp [
super setUp.
oldLogger := DSSpy logger.
Expand All @@ -20,27 +21,27 @@ DSSTONFileLoggerTest >> setUp [
task := DSTask new
]

{ #category : #running }
{ #category : 'running' }
DSSTONFileLoggerTest >> tearDown [

DSSpy logger: oldLogger.
super tearDown
]

{ #category : #'tests - file handling' }
{ #category : 'tests - file handling' }
DSSTONFileLoggerTest >> testDefaultLoggingDirectoryName [

self
assert: logger defaultLoggingDirectoryName
equals: 'ds-spy'
]

{ #category : #'tests - file handling' }
{ #category : 'tests - file handling' }
DSSTONFileLoggerTest >> testDefaultLoggingFileName [
self assert: logger defaultLoggingFileName equals: SessionManager default currentSession id asString
]

{ #category : #'tests - file handling' }
{ #category : 'tests - file handling' }
DSSTONFileLoggerTest >> testEnsureCreateLoggingFileReference [

| fileReference |
Expand All @@ -51,7 +52,7 @@ DSSTONFileLoggerTest >> testEnsureCreateLoggingFileReference [
self assert: fileReference exists
]

{ #category : #'tests - task management' }
{ #category : 'tests - task management' }
DSSTONFileLoggerTest >> testFilenameForSurvey [
|fnameStream|
fnameStream := (logger filenameForSurvey: survey) readStream.
Expand All @@ -60,7 +61,7 @@ DSSTONFileLoggerTest >> testFilenameForSurvey [
self assert: (fnameStream readStream upToEnd) equals: logger surveyFileExtension
]

{ #category : #'tests - task management' }
{ #category : 'tests - task management' }
DSSTONFileLoggerTest >> testForceLoggingFileNameFor [
logger reset.
logger forceLoggingFileNameFor: task.
Expand All @@ -69,7 +70,7 @@ DSSTONFileLoggerTest >> testForceLoggingFileNameFor [
self assert: logger loggingFileReference exists
]

{ #category : #'tests - task management' }
{ #category : 'tests - task management' }
DSSTONFileLoggerTest >> testForceRunningTask [

DSSpy resetSpy.
Expand All @@ -80,23 +81,23 @@ DSSTONFileLoggerTest >> testForceRunningTask [
task title , '-' , SessionManager default currentSession id asString
]

{ #category : #'tests - file handling' }
{ #category : 'tests - file handling' }
DSSTONFileLoggerTest >> testLoggingDirectory [

self
assert: logger loggingDirectory
equals: logger defaultLoggingDirectoryName asFileReference
]

{ #category : #'tests - file handling' }
{ #category : 'tests - file handling' }
DSSTONFileLoggerTest >> testLoggingFileName [

self
assert: logger loggingFileName
equals: logger defaultLoggingFileName
]

{ #category : #'tests - file handling' }
{ #category : 'tests - file handling' }
DSSTONFileLoggerTest >> testLoggingFileNameAfterTaskEnded [

DSSpy startTask: task.
Expand All @@ -106,7 +107,7 @@ DSSTONFileLoggerTest >> testLoggingFileNameAfterTaskEnded [
equals: logger defaultLoggingFileName
]

{ #category : #'tests - file handling' }
{ #category : 'tests - file handling' }
DSSTONFileLoggerTest >> testLoggingFileNameAfterTaskStarted [

DSSpy startTask: task.
Expand All @@ -116,7 +117,7 @@ DSSTONFileLoggerTest >> testLoggingFileNameAfterTaskStarted [
equals: (task title, '-', logger defaultLoggingFileName)
]

{ #category : #'tests - file handling' }
{ #category : 'tests - file handling' }
DSSTONFileLoggerTest >> testLoggingFileReference [

| fileReference |
Expand All @@ -127,7 +128,7 @@ DSSTONFileLoggerTest >> testLoggingFileReference [
self assert: fileReference exists
]

{ #category : #tests }
{ #category : 'tests' }
DSSTONFileLoggerTest >> testReset [
logger forceLoggingFileNameFor: task.
logger reset.
Expand All @@ -136,12 +137,12 @@ DSSTONFileLoggerTest >> testReset [
equals: logger defaultLoggingFileName
]

{ #category : #'tests - task management' }
{ #category : 'tests - task management' }
DSSTONFileLoggerTest >> testSurveyFileExtension [
self assert: logger surveyFileExtension equals: 'survey'
]

{ #category : #'tests - logging' }
{ #category : 'tests - logging' }
DSSTONFileLoggerTest >> testWriteToFile [

| str |
Expand Down
Loading
Loading