Skip to content

Fix issue when no GitHub token is specified #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sneko wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix issue when no GitHub token is specified #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,7 @@ module.exports.getGithubCommit = async (build, octokit) => {
// subscribe is the main function called by GCF.
module.exports.subscribe = async (event) => {
try {
const token = process.env.GITHUB_TOKEN;
const octokit = token && new Octokit({
auth: `token ${token}`,
});
// Format data
const build = module.exports.eventToBuild(event.data);

// Skip if the current status is not in the status list.
Expand All @@ -43,9 +40,20 @@ module.exports.subscribe = async (event) => {
return;
}

const githubCommit = await module.exports.getGithubCommit(build, octokit);
// If specified get information from GitHub
const token = process.env.GITHUB_TOKEN;
let githubCommit = null;
if (token) {
const octokit = token && new Octokit({
auth: `token ${token}`,
});

githubCommit = await module.exports.getGithubCommit(build, octokit);
}

// Format final message
const message = await module.exports.createSlackMessage(build, githubCommit);

// Send message to slack.
module.exports.webhook.send(message);
} catch (err) {
Expand Down