Fix: missed culture in date-time conversions#8
Open
Shiko1st wants to merge 6 commits intoPierluigiMari:mainfrom
Open
Fix: missed culture in date-time conversions#8Shiko1st wants to merge 6 commits intoPierluigiMari:mainfrom
Shiko1st wants to merge 6 commits intoPierluigiMari:mainfrom
Conversation
added 6 commits
January 8, 2026 15:19
… (no hardcoded shift anymore) when local culture is non-western.
…augmented with some helping members.
… eliminated. Model data is created once then used as expectation to compare actual values with. Culture is used where was missed.
…machine is non-western. All and any mock data were extracted into fields or constants, then used as expectation to compare actual values with. All hardcoded strings or values have been eliminated. Actual values are now compared with respect to used ClassMap. No more hardcoded comparison transformations (we belive that used conversions are correct as they should be tested elsewhere). All comparisons are unified, the same data as written is used in validations. Cell address in excel-style (like A1) is used to identify the cell being validated.
…culture and then parse it. This approach seems to be more universal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes fix problems with missed culture in parsers and tests failed when local culture is non-western.
ExcelDateTimeOffsetConverterTestsandExcelDateTimeOffsetTextConverterTestshad hardcoded timeshift in test data. This was rewritten with respect to actual local time shift.The planned development is to use non-US and non-Invariant cultures to test parsers and writer.
p.s. sorry for such a big rewrite but I'm very interested in this library and its evolution so I was needed to ensure it will work and pass tests in my environments. Thas is why I've started all this.