Suggestion for behaviour change when correcting#16
Open
brunocbr wants to merge 12 commits intoPillFall:developfrom
Open
Suggestion for behaviour change when correcting#16brunocbr wants to merge 12 commits intoPillFall:developfrom
brunocbr wants to merge 12 commits intoPillFall:developfrom
Conversation
PillFall
requested changes
Dec 8, 2022
Owner
There was a problem hiding this comment.
Hi, I didn't check your code in deep, but I believe all the cl package is deprecated for Emacs 26 and deleted by Emacs 29.
Also, I couldn't merge this pull request as this will also merge the release commits, you must cherry-pick yours commits into develop or git will mess up with the branches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I may suggest the following modifications:
SPCto exitlanguagetool-correct-bufferwithout throwing an error.These changes yield a better workflow when doing manual corrections (in contrast to cases when accepting suggested corrections is sufficient).
This PR also fixes a bug with the overlays sometimes being scanned in the wrong order.