ci(tikv/migration): remove pull_unit_test job#4301
Conversation
![ti-chi-bot[bot]](https://avatars.githubusercontent.com/in/214286?s=60&v=4){kind=small}
There was a problem hiding this comment.
I have already done a preliminary review for you, and I hope to help you do a better job.
Summary
This PR removes the pull_unit_test Jenkins presubmit job from the TiKV Migration repo, including its job DSL, pipeline script, pod template, and related presubmit configuration in Prow. The approach taken is a straightforward deletion of all artifacts related to this job. The changes are clean and focused, with no extraneous modifications, reflecting a solid cleanup effort.
Critical Issues
- None found. The PR cleanly removes all references to the deprecated job.
Code Improvements
-
prow-jobs/tikv/migration/latest-presubmits.yaml (lines 27-43)
The removal of thepull_unit_testpresubmit is straightforward and correct. However, it would be good to verify no other jobs depend on this presubmit or share its context (pull-unit-test).Suggested improvement: After removal, confirm that no stale references to
pull-unit-testcontext remain in the repo or CI dashboards to prevent confusing failures or alerts.
Best Practices
-
Commit message clarity
The PR description is clear, but the commit message (title + description) should ideally mention the rationale behind removing this job, e.g., if it is replaced by another test job or no longer needed.Suggested commit message addition example:
ci(tikv/migration): remove pull_unit_test job This job is deprecated and replaced by [new job name or reason]. Removing to reduce maintenance overhead. - Removed pull_unit_test from prow presubmits - Deleted Jenkins job DSL and pipeline scripts - Deleted related pod template YAML Fixes #4300 Related to #4215 -
Testing and verification
The PR does not mention any testing done after removal. It’s recommended to verify that:- The presubmit job no longer appears or triggers on PRs
- There are no errors in presubmit job generation pipelines after removal
- No dependent pipelines or jobs break due to missing pod templates or scripts
Adding a short manual verification note in the PR description or as a checklist would help reviewers gain confidence.
No other issues detected. The PR is well focused on cleanup and properly deletes all relevant files and config entries.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on cleaning up the CI/CD infrastructure by completely removing an obsolete unit test job. This includes deleting its configuration from Prow, its Jenkins job definition, and the corresponding pipeline script and Kubernetes pod template. The change streamlines the CI setup by eliminating components that are no longer needed, following up on previous refactoring efforts. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the pull_unit_test presubmit job for tikv/migration. The changes include deleting the Jenkins job DSL, the pipeline script, the pod template, and removing the job definition from the Prow presubmits configuration. The changes are straightforward and correctly remove all components related to the specified CI job. The removal is clean and complete.
|
Depends on tikv/migration#431 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
deleted the
copilot/sub-pr-4300-remove-migration-unit-test
branch
…istry (#4272) Migrates `tikv/migration` integration CI jobs from `fileserver.pingcap.net` to OCI artifacts in `hub-zot.pingcap.net/mirrors/hub`. ## Changes - update `pull_integration_test.groovy` and `pull_integration_kafka_test.groovy` to prepare integration binaries via OCI - preserve `make prepare_test_binaries` semantics by downloading required artifacts into `cdc/scripts/bin` (`tidb-server`, `tikv-server`, `pd-server`, `pd-ctl`, `etcdctl`, `go-ycsb`) - set `OCI_ARTIFACT_HOST` to `hub-zot.pingcap.net/mirrors/hub` in integration pipelines - add `utils` sidecar (`ghcr.io/pingcap-qe/cd/utils/release`) in integration pod templates for OCI tooling support - keep integration presubmit triggers in `prow-jobs/tikv/migration/latest-presubmits.yaml` with shared YAML anchors ## Follow-up split out - `pull_unit_test` removal is tracked separately in #4300 and implemented in #4301 Fixes #4215 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: wuhuizuo <2574558+wuhuizuo@users.noreply.github.com> Co-authored-by: wuhuizuo <wuhuizuo@126.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
1 participant
Summary
pull_unit_testpresubmit fromprow-jobs/tikv/migration/latest-presubmits.yamljobs/tikv/migration/latest/pull_unit_test.groovypipelines/tikv/migration/latest/Context
Fixes #4300
Related to #4215