Add Turnstile functionality and fallback support #17
+516
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinesoftware
commented
Nov 24, 2025
shinesoftware
commented
- Implemented methods in Turnstile block to check if Turnstile is enabled, retrieve site key, and manage form settings.
- Enhanced turnstile.phtml to utilize new block methods for configuration and added fallback for themes without Knockout.js.
- Introduced fallback.js to handle rendering when Knockout.js is unavailable.
- Updated CSS for improved styling of Turnstile elements.
- Included fallback.js in the layout for frontend integration.
- Implemented methods in Turnstile block to check if Turnstile is enabled, retrieve site key, and manage form settings. - Enhanced turnstile.phtml to utilize new block methods for configuration and added fallback for themes without Knockout.js. - Introduced fallback.js to handle rendering when Knockout.js is unavailable. - Updated CSS for improved styling of Turnstile elements. - Included fallback.js in the layout for frontend integration.
Author
|
Please merge the changes so I can use them into our project, thanks for your help! |
added 7 commits
November 24, 2025 20:39
- Added storefront setting for selecting widget rendering mode (Knockout vs Hyvä/Alpine fallback). - Ensured only one renderer executes at a time to prevent Cloudflare "sitekey object" errors. - Introduced dedicated fallback container class (`cf-turnstile-manual`) to prevent auto-rendering on Hyvä widgets. - Enhanced frontend/admin CSS and JS to respect the selected rendering mode.
- Changed package name from shinesoftware/magento-cloudflare-turnstile to pixelopen/cloudflare-turnstile-bundle. - Refactored error handling in component.js to ensure the error message is displayed only when the site key is missing. - Cleaned up formatting in turnstile.phtml for better readability.
- Updated the getValue method in component.js to utilize optional chaining when checking if the value is an observable, enhancing code robustness.
- Adjusted CSS rules for `.cf-turnstile-manual` and `.cloudflare-turnstile .cf-turnstile` to improve layout consistency. - Ensured proper margin and minimum height settings for better visual alignment in both admin and frontend styles.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.