Fix DB session corruption crashing pipeline tasks#532
Merged
Conversation
When token_metrics_store fails to commit, the corrupted session state propagates to _handle_task_completion, which fails to read the task from the DB and crashes the Luigi task — even though the LLM work already succeeded. Changes: - Use db.session.remove() instead of close()/expire_all() for stronger scoped session cleanup that fully discards corrupted state - Increase retry attempts from 2 to 3 in _handle_task_completion - On final DB failure, log error and continue pipeline instead of raising — the actual work already completed successfully - Add db.session.remove() to token_metrics_store error handler to prevent corrupted session from poisoning subsequent operations Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
token_metrics_storefails to commit, the corrupted DB session propagates to_handle_task_completion, which crashes the entire Luigi task — even though the LLM work already succeededdb.session.remove()(stronger thanclose()) to fully discard corrupted scoped sessionsdb.session.remove()totoken_metrics_storeerror handler to prevent session corruption from propagatingTest plan
luigi_workers=4and verify noExtractConstraintsTaskcrashes from DB errors🤖 Generated with Claude Code