Deeper clean up #15
Deeper clean up #15
Conversation
…ventions.html Bump kotlin version to 1.1
# Conflicts: # app/src/main/kotlin/io/github/plastix/kotlinboilerplate/data/network/NetworkInteractorImpl.kt # app/src/main/kotlin/io/github/plastix/kotlinboilerplate/data/remote/ApiModule.kt # app/src/main/kotlin/io/github/plastix/kotlinboilerplate/extensions/ViewExtensions.kt # app/src/main/kotlin/io/github/plastix/kotlinboilerplate/ui/detail/DetailActivity.kt # app/src/main/kotlin/io/github/plastix/kotlinboilerplate/ui/list/ListActivity.kt
|
I've already merged the first two commits of this PR into |
|
I added them to allow GitHub merge for you. Don't worry - these changes are not visible on Files changed. Example: ViewModelLoader was changed on 2aa57b1 but there is nothing about it on Files changed because it is already in Plastix:master (thanks to the previous merge). |
Plastix
left a comment
Plastix
left a comment
There was a problem hiding this comment.
Once you fix the small changes can you squash into one commit?
| fun provideApiService(retrofit: Retrofit): GithubApiService { | ||
| return retrofit.create(GithubApiService::class.java) | ||
| } | ||
| fun provideApiService(retrofit: Retrofit) = retrofit.create(GithubApiService::class.java)!! |
There was a problem hiding this comment.
To avoid phantom type that is returned by create function, while it is Java function. It can be either solved by not null assertion (!!) or by setting function type. In situations like this, where it is obvious for all experienced Android developers that this will return GithubApiService I prefer to use !! because it is shorter. But I can change to:
fun provideApiService(retrofit: Retrofit): GithubApiService =
retrofit.create(GithubApiService::class.java)
what is also totally reasonable.
There was a problem hiding this comment.
I think the explicit return type is better.
| } | ||
|
|
||
| private fun onRequestError(e: Throwable) { | ||
| System.out.println(e.toString()) |
|
|
||
| class ListViewModel @Inject constructor( | ||
| private val apiService: GithubApiService, | ||
| apiService: GithubApiService, |
There was a problem hiding this comment.
Is there a reason for making apiService not a private val anymore?
There was a problem hiding this comment.
I noticed that one of your next commits fixes this so nevermind.
2 participants
No description provided.