Skip to content

updating github api called in PF Editor for checking updates #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlonsoMondal wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −10
Open

updating github api called in PF Editor for checking updates #903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...unity-v2/source/ExampleTestProject/Assets/PlayFabEditorExtensions/Editor/PlayFabEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ private static void GetLatestEdExVersion()

if (DateTime.Today > threshold)
{
PlayFabEditorHttp.MakeGitHubApiCall("https://api.github.com/repos/PlayFab/UnitySDK/git/refs/tags", (version) =>
PlayFabEditorHttp.MakeGitHubApiCall("https://api.github.com/repos/PlayFab/UnitySDK/releases/latest", (version) =>
{
latestEdExVersion = version ?? "Unknown";
PlayFabEditorPrefsSO.Instance.EdSet_latestEdExVersion = latestEdExVersion;
Expand Down
2 changes: 1 addition & 1 deletion ...TestProject/Assets/PlayFabEditorExtensions/Editor/Scripts/Panels/PlayFabEditorSDKTools.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ private static void GetLatestSdkVersion()

if (DateTime.Today > threshold)
{
PlayFabEditorHttp.MakeGitHubApiCall("https://api.github.com/repos/PlayFab/UnitySDK/git/refs/tags", (version) =>
PlayFabEditorHttp.MakeGitHubApiCall("https://api.github.com/repos/PlayFab/UnitySDK/releases/latest", (version) =>
{
latestSdkVersion = version ?? "Unknown";
PlayFabEditorPrefsSO.Instance.EdSet_latestSdkVersion = latestSdkVersion;
Expand Down
13 changes: 5 additions & 8 deletions ...oject/Assets/PlayFabEditorExtensions/Editor/Scripts/PlayFabEditorSDK/PlayFabEditorHttp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,18 +60,15 @@ private static void OnGitHubSuccess(Action<string> resultCallback, string respon
if (resultCallback == null)
return;

var jsonResponse = JsonWrapper.DeserializeObject<List<object>>(response);
if (jsonResponse == null || jsonResponse.Count == 0)
var jsonResponse = JsonWrapper.DeserializeObject<JsonObject>(response);
if (jsonResponse == null)
return;

// list seems to come back in ascending order (oldest -> newest)
var latestSdkTag = (JsonObject)jsonResponse[jsonResponse.Count - 1];
// The /releases/latest endpoint returns a single object with a "tag_name" field
object tag;
if (latestSdkTag.TryGetValue("ref", out tag))
if (jsonResponse.TryGetValue("tag_name", out tag) && tag != null)
{
var startIndex = tag.ToString().LastIndexOf('/') + 1;
var length = tag.ToString().Length - startIndex;
resultCallback(tag.ToString().Substring(startIndex, length));
resultCallback(tag.ToString());
}
else
{
Expand Down