Update POL_SetupFrame.py - Fix syntax warning with Python >= 3.10#81
Update POL_SetupFrame.py - Fix syntax warning with Python >= 3.10#81BorislavSabev wants to merge 1 commit intoPlayOnLinux:masterfrom
Conversation
|
Thank you for your merge request. No problem to release a 4.4.1 version. Can you confirm that your work is backward compatible with older python versions? |
|
@qparis which Python versions must be supported here?
Python 2.x is not supported by this code. Basically it should be OK as it is fully compatible with 3.3 -> 3.12+ |
|
Do you know what version is included in most distributions? |
|
All distributions seem to be above that except RHEL 8 / Rocky Linux 8 After some checks: |
|
@qparis is someone else going to check these changes? I mean make a test outside of my dev testing 🗡️ |
|
Yes I will test it |
Description
PlayOnLinux fails to start with Python >= 3.10 because of the following syntax error:
This was observed on Fedora 43.
A reported BUG exists on RedHat's bug tracker as well.
With this PR I'm making the same patch as suggested in that report but directly to the upstream repository here.
Please review it asap.
Also are you planning to release 4.4.1 soon? It can see that there are a bunch of commits after that tag in master and it would be great if this fix can make it into a "version 4.4.1".