Fix Angular compiler version mismatch, npm security vulnerabilities, deprecation warnings, and update Node.js version#71
Conversation
Co-authored-by: rbergen <10425218+rbergen@users.noreply.github.com>
|
@copilot npm now reports 13 high severity security issues. Can you fix these? |
|
@rbergen The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
|
@copilot npm now reports 13 high severity security issues. Can you fix these? |
Co-authored-by: rbergen <10425218+rbergen@users.noreply.github.com>
Fixed in commit |
|
@copilot I see this line in the build-web CI output: Furthermore, npm complains that the NodeJS version used is too old for quite a number of packages. Please update CI to use a 20.x NodeJS runtime instead. |
Co-authored-by: rbergen <10425218+rbergen@users.noreply.github.com>
Co-authored-by: rbergen <10425218+rbergen@users.noreply.github.com>
Fixed in commits The 12 vulnerabilities were due to the package-lock.json being generated with an older npm version. Regenerating it with a fresh CI now uses Node.js 20.x which eliminates all EBADENGINE warnings for packages requiring Node 20+. |
|
Deleted. |
|
@copilot Can you address these deprecation warnings as well? Notes:
|
- Updated glob from 10.5.0 to 13.0.6 (latest stable) - Added jsdom override to use version ^28.1.0 - Added html-encoding-sniffer override to use version ^6.0.0 - These changes eliminate whatwg-encoding dependency entirely (replaced with @exodus/bytes) - Regenerated package-lock.json with npm install --legacy-peer-deps - Verified build still works and npm audit shows 0 vulnerabilities Co-authored-by: rbergen <10425218+rbergen@users.noreply.github.com>
... Fixed in commit Changes made:
Verification:
The functionality of the web application is preserved - all changes are to test/dev dependencies (jsdom is used by jest for testing). |
a698dca
into
dependabot/npm_and_yarn/ndsweb/npm_and_yarn-26c0fdf869
The dependabot bump of
@angular/coreto19.2.20exposed a pre-existing typo inpackage.json:@angular/compilerwas set to~21.2.4instead of a v19 release, causing a hard build failure:Additionally, resolved npm security vulnerabilities by regenerating the package-lock.json with a modern npm version, updated the CI workflow to use Node.js 20, and addressed npm deprecation warnings for
whatwg-encodingandglob.Changes
ndsweb/package.json@angular/compiler:~21.2.4→~19.2.20@angular/compiler-cli:~19.2.18→~19.2.20glob:10.5.0→13.0.6(eliminates security vulnerabilities)jsdom:^28.1.0,html-encoding-sniffer:^6.0.0(eliminates deprecatedwhatwg-encoding)ndsweb/package-lock.jsonnpm install --legacy-peer-depsto resolve all npm security vulnerabilities and deprecation warningswhatwg-encodingorglob.github/workflows/CI.yml18to20to eliminate EBADENGINE warnings for packages requiring Node 20+Both Angular compiler packages now align with
@angular/coreat~19.2.20, all npm security issues have been resolved, all deprecation warnings have been addressed, and the CI environment now uses an appropriate Node.js version for the project's dependencies. The deprecatedwhatwg-encodingpackage has been completely removed from the dependency tree, replaced by@exodus/bytesthrough updated transitive dependencies.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.