Skip to content

Mimic __getstate__ logic for dict parsing in pydantic serialization #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Mimic __getstate__ logic for dict parsing in pydantic serialization #486

wants to merge 2 commits into from

Conversation

@NeejWeej
Copy link
Collaborator

No description provided.

@NeejWeej
Mimic __getstate__ logic for dict parsing in pydantic serialization
0e3fc6f 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
@NeejWeej NeejWeej added type: enhancement Issues and PRs related to improvements to existing features lang: python Issues and PRs related to the Python codebase labels Mar 13, 2025
ptomecek
ptomecek requested changes Oct 27, 2025
View reviewed changes
Copy link
Collaborator

@ptomecek ptomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you take an example where this wasn't equivalent before and create a unit test from it?

@NeejWeej
Copy link
Collaborator Author

Can you take an example where this wasn't equivalent before and create a unit test from it?

It should be equivalent, the only difference is that we skip a hasattr check by using csp.UNSET, which is a micro-optimization but can add up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ptomecek ptomecek ptomecek requested changes

@robambalu robambalu Awaiting requested review from robambalu robambalu is a code owner

@AdamGlustein AdamGlustein Awaiting requested review from AdamGlustein AdamGlustein is a code owner

@svatasoiu svatasoiu Awaiting requested review from svatasoiu svatasoiu is a code owner

@alexddobkin alexddobkin Awaiting requested review from alexddobkin alexddobkin is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

lang: python Issues and PRs related to the Python codebase type: enhancement Issues and PRs related to improvements to existing features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NeejWeej @ptomecek @timkpaine