Skip to content

Added new p1_capture utility, and simplified TCP/UDP/serial example apps.#347

Merged
adamshapiro0 merged 17 commits intomasterfrom
summary
Dec 9, 2024
Merged

Added new p1_capture utility, and simplified TCP/UDP/serial example apps.#347
adamshapiro0 merged 17 commits intomasterfrom
summary

Conversation

@adamshapiro0
Copy link
Collaborator

@adamshapiro0 adamshapiro0 commented Dec 9, 2024

New Features

  • Added new p1_capture tool to display incoming FE messages in real time and capture to disk
    • Combines logic formerly in example tcp_client.py, udp_client.py, and serial_client.py applications
    • Adds new --summary mode to display a summary of device and FusionEngine message status in real time similar to p1_print --summary

Changes

  • Added device type, ID, and software version to p1_print --summary
  • Drastically simplified tcp_client.py, udp_client.py, and serial_client.py example apps
    • Use p1_capture for fully-featured real time capture and display instead

Fixes

  • Use serial/socket read timeouts so we print some console update if there's no incoming data

@adamshapiro0
Pass logger to print_message() helper function.
05a4ff6
@adamshapiro0
Added print_summary_table() helper function.
c4141b3
@adamshapiro0
Configure/use logging in serial_client example app.
4edae40
@adamshapiro0
Added single _print_status() call.
9c78f6f
@adamshapiro0
Set serial read timeout so status prints if there's no incoming data.
c707757
@adamshapiro0
Handle keyboard interrupts during log prints gracefully.
5637761
@adamshapiro0
Added --summary mode to serial_client example app.
78f796a
@adamshapiro0
Refactored TCP/serial clients to use a common implementation.
b0df187 
These apps are identical except for the type of transport they use.
@adamshapiro0
Added CSV output format to TCP/serial clients.
b3cf001
@adamshapiro0
Use common implementation for UDP client too.
82f6a8c
@adamshapiro0
Use select to apply a read timeout for TCP/UDP sockets.
be1ab0a
@adamshapiro0
Use consistent read timeouts on all transports.
be77cb8
@adamshapiro0
Include device ID, type, and SW version in summary table.
770e6e0
@adamshapiro0 adamshapiro0 requested a review from axlan December 9, 2024 17:28
@adamshapiro0 adamshapiro0 self-assigned this Dec 9, 2024
@adamshapiro0
Added p1_capture application, and simplified TCP/UDP/serial example a…
85ad571 
…pps.

The examples are not intended to be fully featured applications, just very
simple examples.
@adamshapiro0
Added p1_filter description to README.
763ea6b
axlan
axlan approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@axlan axlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamshapiro0 adamshapiro0 merged commit 15e3935 into master Dec 9, 2024
13 checks passed
@adamshapiro0 adamshapiro0 deleted the summary branch December 9, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@axlan axlan axlan approved these changes

Assignees

@adamshapiro0 adamshapiro0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adamshapiro0 @axlan