Skip to content

Simulation to-input-dataframe saves variable time periods which are i… #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikhilwoodruff merged 5 commits into from
Jul 12, 2025
Merged

Simulation to-input-dataframe saves variable time periods which are i… #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
042c742
Simulation to-input-dataframe saves variable time periods which are i…
nikhilwoodruff Jul 12, 2025
84a71ce
Format
nikhilwoodruff Jul 12, 2025
484779c
Fix bug
nikhilwoodruff Jul 12, 2025
e85835f
Add print statement
nikhilwoodruff Jul 12, 2025
3a758d4
More rigorously infer time period
nikhilwoodruff Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog_entry.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- bump: patch
changes:
fixed:
- Bug causing to_input_dataframe to include bad time periods.
10 changes: 9 additions & 1 deletion policyengine_core/simulations/simulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1502,7 +1502,11 @@ def to_input_dataframe(
df = pd.DataFrame()

for variable in self.tax_benefit_system.variables:
variable_meta = self.tax_benefit_system.variables[variable]
for period in self.get_holder(variable).get_known_periods():
# Test if period matches entity definition period
if variable_meta.definition_period != period.unit:
continue
values = self.calculate(variable, period, map_to="person")
if values is not None:
df[f"{variable}__{period}"] = values
Expand Down Expand Up @@ -1561,7 +1565,11 @@ def subsample(
df = self.to_input_dataframe()

# Extract time period from DataFrame columns
df_time_period = df.columns.values[0].split("__")[1]
df_time_period = (
df.columns[df.columns.str.contains("household_id__")]
.values[0]
.split("__")[1]
)
df_household_id_column = f"household_id__{df_time_period}"
df_person_id_column = f"person_id__{df_time_period}"

Expand Down