Add subdirectory support for hf:// URLs and gs:// scheme for GCS#406
Merged
Add subdirectory support for hf:// URLs and gs:// scheme for GCS#406
Conversation
17d4673 to
8920e59
Compare
- Add parse_hf_url() helper function to centralize hf:// URL parsing - Support subdirectory paths: hf://owner/repo/path/to/file.h5[@Version] - Add google_cloud.py module with parse_gs_url(), download_gcs_file(), upload_gcs_file() - Support gs:// URLs: gs://bucket/path/to/file.h5[@Version] - Update dataset.py download/upload methods for both schemes - Update simulation.py dataset initialization for both schemes - google-cloud-storage is optional - raises helpful ImportError if not installed Closes #405 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
8920e59 to
bf95770
Compare
Collaborator
Author
|
I just tested this manually as well: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hf://URLs (e.g.,hf://owner/repo/path/to/file.h5)gs://URL scheme for Google Cloud Storage (e.g.,gs://bucket/path/to/file.h5)Changes
hf:// improvements
parse_hf_url()helper function to centralize URL parsinghf://owner/repo/path/to/file.h5[@version]dataset.pyandsimulation.pygs:// new functionality
google_cloud.pymodule withparse_gs_url(),download_gcs_file(),upload_gcs_file()gs://bucket/path/to/file.h5[@version]google-cloud-storageis optional - raises helpfulImportErrorif not installedTest plan
parse_hf_url()parse_gs_url()Closes #405
🤖 Generated with Claude Code