Skip to content

Fix LCFS income/weights, add --uprate-to flag#3

Merged
nikhilwoodruff merged 1 commit intomainfrom
lcfs-income-weights-spi-was-2026
Apr 2, 2026
Merged

Fix LCFS income/weights, add --uprate-to flag#3
nikhilwoodruff merged 1 commit intomainfrom
lcfs-income-weights-spi-was-2026

Conversation

@nikhilwoodruff
Copy link
Copy Markdown
Contributor

@nikhilwoodruff nikhilwoodruff commented Apr 2, 2026

Summary

  • Fix Python interface CLI flags broken since binary renamed them in 0.3.5: --data-dir/--clean-frs-base/--clean-frs--data, --frs-raw--frs. Fixes all economy-wide simulations failing with "unexpected argument '--clean-frs-base' found"
  • Fix LCFS income columns: wkgrossp for employment (was sparse b315p), p047p+b3262p for SE, p048p for investment income
  • Fix LCFS weights: rescale weighta (design weight ~28k) to UK household population (~28.3m)
  • Add --uprate-to YYYY flag to --extract mode

Result

  • Python interface economy-wide simulations work again
  • LCFS +1p basic rate score: £0.01bn (broken) → £7.7bn (consistent with FRS £7.2bn, SPI £7.6bn)

Test plan

  • cargo test passes
  • Simulation(year=2026, clean_frs_base="data/frs").run() works without CLI errors

- LCFS: wkgrossp for employment income, p047p+b3262p for SE, p048p
  for investment income; rescale weighta to UK household population
- Add --uprate-to flag to --extract: uprate before writing clean CSVs
- Update SKILL.md to document new flag
@nikhilwoodruff nikhilwoodruff marked this pull request as ready for review April 2, 2026 13:46
@nikhilwoodruff nikhilwoodruff merged commit a7ad94a into main Apr 2, 2026
1 check passed
@nikhilwoodruff nikhilwoodruff deleted the lcfs-income-weights-spi-was-2026 branch April 2, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant