Skip to content

Fix PUF SOI aggregate path fallback#690

Closed
MaxGhenis wants to merge 2 commits intoPolicyEngine:mainfrom
MaxGhenis:codex/fix-puf-soi-path
Closed

Fix PUF SOI aggregate path fallback#690
MaxGhenis wants to merge 2 commits intoPolicyEngine:mainfrom
MaxGhenis:codex/fix-puf-soi-path

Conversation

@MaxGhenis
Copy link
Copy Markdown
Contributor

@MaxGhenis MaxGhenis commented Apr 5, 2026

Summary

  • make the PUF uprater load SOI aggregates lazily from storage/calibration_targets/soi_targets.csv
  • remove the stale dependency on storage/soi.csv
  • drop the now-dead soi.csv private prerequisite download
  • add focused unit coverage for the tracked-path and missing-file cases

Validation

  • UV_PYTHON=3.14 uv run pytest tests/unit/datasets/test_uprate_puf.py -q
  • UV_PYTHON=3.14 uv run ruff check policyengine_us_data/datasets/puf/uprate_puf.py policyengine_us_data/storage/download_private_prerequisites.py tests/unit/datasets/test_uprate_puf.py
  • UV_PYTHON=3.14 uv run ruff format --check policyengine_us_data/datasets/puf/uprate_puf.py policyengine_us_data/storage/download_private_prerequisites.py tests/unit/datasets/test_uprate_puf.py
  • manual repro: fresh PUF_2021().generate() now gets past the previous NameError: soi is not defined crash

@MaxGhenis
Copy link
Copy Markdown
Contributor Author

Closing this fork-based PR in favor of an upstream-branch PR so CI can run.

@MaxGhenis MaxGhenis closed this Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant