Skip to content

Fix PUF SOI aggregate path fallback#691

Merged
MaxGhenis merged 3 commits intomainfrom
codex/fix-puf-soi-path
Apr 6, 2026
Merged

Fix PUF SOI aggregate path fallback#691
MaxGhenis merged 3 commits intomainfrom
codex/fix-puf-soi-path

Conversation

@MaxGhenis
Copy link
Copy Markdown
Contributor

Summary

  • make the PUF uprater load SOI aggregates lazily from storage/calibration_targets/soi_targets.csv
  • remove the stale dependency on storage/soi.csv
  • drop the now-dead soi.csv private prerequisite download
  • add focused unit coverage for the tracked-path and missing-file cases

Validation

  • UV_PYTHON=3.14 uv run pytest tests/unit/datasets/test_uprate_puf.py -q
  • UV_PYTHON=3.14 uv run ruff check policyengine_us_data/datasets/puf/uprate_puf.py policyengine_us_data/storage/download_private_prerequisites.py tests/unit/datasets/test_uprate_puf.py
  • UV_PYTHON=3.14 uv run ruff format --check policyengine_us_data/datasets/puf/uprate_puf.py policyengine_us_data/storage/download_private_prerequisites.py tests/unit/datasets/test_uprate_puf.py
  • manual repro: fresh PUF_2021().generate() now gets past the previous NameError: soi is not defined crash

@MaxGhenis MaxGhenis merged commit fb96f57 into main Apr 6, 2026
9 checks passed
@MaxGhenis MaxGhenis deleted the codex/fix-puf-soi-path branch April 6, 2026 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant