This repository was archived by the owner on Dec 28, 2024. It is now read-only.
Disabled items can't be selected#107
Open
reinert wants to merge 1 commit intoPolymerElements:masterfrom
Open
Conversation
Contributor
Author
|
Also, should there be a feature toggle like |
Contributor
|
Hey, just wanted to let you know this PR hasn't gone unnoticed and we'll get to it soon. Ping me here if 'soon' stops being accurate. |
Contributor
Author
|
Ok. I will. |
Contributor
Author
|
Idea: provide an |
Contributor
|
btw, I was poking around in paper-radio-group and found that it also implements this: https://github.com/PolymerElements/paper-radio-group/blob/3ee7a79/paper-radio-group.html#L164 |
Contributor
Author
|
Good! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial proposed solution for #99.
Basically it prevents
selectmethod to set a disabled item as selected. AlsoselectNextandselectPreviousare covered: they try to find the nearest enabled item. These three methods now returntrueif an item was selected orfalseotherwise.Not covered situations yet: