This repository was archived by the owner on Dec 19, 2024. It is now read-only.
Expose sizing and position properties from iron-image (update)#92
Open
matthewpull wants to merge 5 commits intoPolymerElements:masterfrom
matthewpull:master
Open
Expose sizing and position properties from iron-image (update)#92matthewpull wants to merge 5 commits intoPolymerElements:masterfrom matthewpull:master
matthewpull wants to merge 5 commits intoPolymerElements:masterfrom
matthewpull:master
Conversation
Contributor
|
Omg, finally looking at this. Sorry about that! @bicknellr for a double check, but this looks okay to me. |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
Is this going to get merged anytime soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60
PR #62 also fixes this issue, but is a year old. This PR is an attempt to gain traction on fixing the issue and includes the two test cases required.
This is my first PR 🎉, so if I have made a rookie mistake or missed anything please let me know and I'll fix my error.
Cheers!