-
Notifications
You must be signed in to change notification settings - Fork 65
Vacuum #2361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Vacuum #2361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the parquet loaders
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 9ac47d7 | Previous: 19470cc | Ratio |
|---|---|---|---|
large/1k fixed edge updates with varying time |
828202 ns/iter (± 5254) |
394370 ns/iter (± 3237) |
2.10 |
large/1k fixed edge updates with varying time and numeric string input |
923658 ns/iter (± 6599) |
416447 ns/iter (± 3646) |
2.22 |
large/1k fixed edge updates with varying time and string input |
958927 ns/iter (± 8877) |
462688 ns/iter (± 5900) |
2.07 |
large/1k random edge additions |
1253634 ns/iter (± 60386) |
575939 ns/iter (± 27237) |
2.18 |
lotr_graph/num_edges |
3 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
192 ns/iter (± 0) |
1 ns/iter (± 0) |
192 |
lotr_graph_window_100/num_edges |
23 ns/iter (± 0) |
6 ns/iter (± 0) |
3.83 |
lotr_graph_window_100/num_nodes |
197 ns/iter (± 1) |
4 ns/iter (± 0) |
49.25 |
lotr_graph_window_10/iterate nodes |
29176 ns/iter (± 52) |
14028 ns/iter (± 29) |
2.08 |
lotr_graph_subgraph_10pc/has_edge_existing |
382 ns/iter (± 19) |
93 ns/iter (± 3) |
4.11 |
lotr_graph_subgraph_10pc/has_node_existing |
174 ns/iter (± 3) |
38 ns/iter (± 5) |
4.58 |
lotr_graph_subgraph_10pc/iterate nodes |
3915 ns/iter (± 14) |
1929 ns/iter (± 3) |
2.03 |
lotr_graph_window_50_layered/num_edges |
82588 ns/iter (± 2113) |
39492 ns/iter (± 494) |
2.09 |
lotr_graph_window_50_layered/num_nodes |
113861 ns/iter (± 10304) |
22727 ns/iter (± 1010) |
5.01 |
lotr_graph_window_50_layered/has_node_existing |
1150 ns/iter (± 168) |
140 ns/iter (± 14) |
8.21 |
lotr_graph_window_50_layered/max_id |
137451 ns/iter (± 10024) |
31158 ns/iter (± 4860) |
4.41 |
lotr_graph_window_50_layered/max_degree |
2480022 ns/iter (± 195673) |
344714 ns/iter (± 8791) |
7.19 |
lotr_graph_window_50_layered/iterate nodes |
177844 ns/iter (± 1156) |
23067 ns/iter (± 71) |
7.71 |
lotr_graph_window_50_layered/iterate edges |
184992 ns/iter (± 521) |
92098 ns/iter (± 245) |
2.01 |
lotr_graph_window_50_layered/max_neighbour_degree |
2958185 ns/iter (± 34302) |
348301 ns/iter (± 923) |
8.49 |
lotr_graph_window_50_layered_materialise/materialize |
7992034 ns/iter (± 396966) |
3781674 ns/iter (± 15919) |
2.11 |
lotr_graph_persistent_window_50_layered/num_edges |
73094 ns/iter (± 2179) |
36101 ns/iter (± 857) |
2.02 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
673331 ns/iter (± 19522) |
242818 ns/iter (± 7028) |
2.77 |
lotr_graph_persistent_window_50_layered/num_nodes |
167049 ns/iter (± 14668) |
37094 ns/iter (± 1407) |
4.50 |
lotr_graph_persistent_window_50_layered/has_node_existing |
1510 ns/iter (± 367) |
205 ns/iter (± 81) |
7.37 |
lotr_graph_persistent_window_50_layered/max_id |
206895 ns/iter (± 8807) |
47646 ns/iter (± 3055) |
4.34 |
lotr_graph_persistent_window_50_layered/max_degree |
3828043 ns/iter (± 165912) |
510331 ns/iter (± 6633) |
7.50 |
lotr_graph_persistent_window_50_layered/iterate nodes |
253503 ns/iter (± 24748) |
45872 ns/iter (± 106) |
5.53 |
lotr_graph_persistent_window_50_layered/max_neighbour_degree |
3948750 ns/iter (± 21955) |
499344 ns/iter (± 1544) |
7.91 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
14628581 ns/iter (± 495594) |
5862863 ns/iter (± 46040) |
2.50 |
lotr_graph/proto_decode |
18751226 ns/iter (± 616449) |
2105220 ns/iter (± 39101) |
8.91 |
lotr_graph/proto_encode |
8237001 ns/iter (± 401961) |
983798 ns/iter (± 23255) |
8.37 |
This comment was automatically generated by workflow using github-action-benchmark.
# Conflicts: # raphtory-api/src/core/entities/properties/prop/prop_enum.rs
8bc5e88 to
69fee1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to enable vacuum + making edge deletion loading sequential (needs testing before reversal)