-
Notifications
You must be signed in to change notification settings - Fork 65
GraphQL improvements for v4 #2416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ljeub-pometry
wants to merge
40
commits into
db_v4
Choose a base branch
from
fix/graphql_v4
base: db_v4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eing mutated. If we allow that to happen, reinserting it doesn't fix anything as the graph might already have been re-cached as well and state is inconsistent.
…cture and refactor the validation logic (compiles but does not work yet)
…gets cleaned up again!
d510502 to
b669122
Compare
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 6bfbced | Previous: 102a9fe | Ratio |
|---|---|---|---|
local_triangle_count/local_triangle_count |
1603139 ns/iter (± 211662) |
706696 ns/iter (± 8298) |
2.27 |
lotr_graph/num_edges |
4 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
79 ns/iter (± 0) |
1 ns/iter (± 0) |
79 |
lotr_graph_materialise/materialize |
3057237 ns/iter (± 3536) |
1468616 ns/iter (± 9419) |
2.08 |
lotr_graph_window_100/num_edges |
27 ns/iter (± 0) |
8 ns/iter (± 0) |
3.38 |
lotr_graph_window_100/num_nodes |
90 ns/iter (± 0) |
5 ns/iter (± 0) |
18 |
lotr_graph_window_100_materialise/materialize |
3412155 ns/iter (± 11335) |
1616091 ns/iter (± 5804) |
2.11 |
lotr_graph_window_10/iterate nodes |
32485 ns/iter (± 79) |
13145 ns/iter (± 247) |
2.47 |
lotr_graph_window_10/iterate edges |
105127 ns/iter (± 445) |
49732 ns/iter (± 628) |
2.11 |
lotr_graph_subgraph_10pc/has_edge_existing |
476 ns/iter (± 5) |
94 ns/iter (± 2) |
5.06 |
lotr_graph_subgraph_10pc/has_node_existing |
230 ns/iter (± 1) |
35 ns/iter (± 0) |
6.57 |
lotr_graph_subgraph_10pc/iterate nodes |
3655 ns/iter (± 13) |
1145 ns/iter (± 3) |
3.19 |
lotr_graph_subgraph_10pc_windowed/iterate nodes |
3923 ns/iter (± 13) |
1763 ns/iter (± 30) |
2.23 |
lotr_graph_window_50_layered/num_nodes |
97960 ns/iter (± 4467) |
23723 ns/iter (± 2295) |
4.13 |
lotr_graph_window_50_layered/has_node_existing |
1294 ns/iter (± 207) |
140 ns/iter (± 15) |
9.24 |
lotr_graph_window_50_layered/max_id |
106022 ns/iter (± 2727) |
30054 ns/iter (± 341) |
3.53 |
lotr_graph_window_50_layered/max_degree |
1986476 ns/iter (± 13998) |
301176 ns/iter (± 12201) |
6.60 |
lotr_graph_window_50_layered/iterate nodes |
246739 ns/iter (± 636) |
22036 ns/iter (± 207) |
11.20 |
lotr_graph_window_50_layered/iterate edges |
214214 ns/iter (± 382) |
94360 ns/iter (± 2143) |
2.27 |
lotr_graph_window_50_layered/max_neighbour_degree |
3605677 ns/iter (± 15121) |
405979 ns/iter (± 4756) |
8.88 |
lotr_graph_window_50_layered_materialise/materialize |
7776929 ns/iter (± 8802) |
3369999 ns/iter (± 23217) |
2.31 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
577313 ns/iter (± 3209) |
213894 ns/iter (± 3659) |
2.70 |
lotr_graph_persistent_window_50_layered/num_nodes |
134175 ns/iter (± 19432) |
33955 ns/iter (± 907) |
3.95 |
lotr_graph_persistent_window_50_layered/has_node_existing |
1666 ns/iter (± 500) |
179 ns/iter (± 93) |
9.31 |
lotr_graph_persistent_window_50_layered/max_id |
146526 ns/iter (± 3357) |
42737 ns/iter (± 2220) |
3.43 |
lotr_graph_persistent_window_50_layered/max_degree |
2883210 ns/iter (± 17532) |
466749 ns/iter (± 14768) |
6.18 |
lotr_graph_persistent_window_50_layered/iterate nodes |
325856 ns/iter (± 951) |
41506 ns/iter (± 354) |
7.85 |
lotr_graph_persistent_window_50_layered/max_neighbour_degree |
4973150 ns/iter (± 76278) |
525340 ns/iter (± 4113) |
9.47 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
13943193 ns/iter (± 25165) |
5151712 ns/iter (± 94249) |
2.71 |
lotr_graph/proto_decode |
19811967 ns/iter (± 105407) |
1911611 ns/iter (± 25778) |
10.36 |
lotr_graph/proto_encode |
9187490 ns/iter (± 150270) |
1153254 ns/iter (± 20173) |
7.97 |
This comment was automatically generated by workflow using github-action-benchmark.
… probably not really helpful anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
fixes #2377 (reenables the tests and fixes serialisation)
fixes #2384
Does this PR introduce any user-facing change? If yes is this documented?
How was this patch tested?
Are there any further changes required?