spatial index, ml dimensions, publish by PondiB · Pull Request #23 · PondiB/openeo-core

PondiB · 2026-02-28T21:52:07Z

No description provided.

Copilot

Pull request overview

This PR extends the ML prediction pipeline to support multi-dimension feature vectors (e.g., flattening ["bands", "t"]), improves performance of certain spatial operations by using spatial indexes, and adds packaging/publishing metadata for distribution.

Changes:

Add dimension to model factory functions and persist feature-dimension metadata through ml_predict and STAC save/load.
Update raster stacking utilities to accept multiple feature dimensions and adjust ML tests accordingly.
Introduce spatial-index based filtering in vector/raster ops, plus PyPI metadata and a release publish workflow.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`openeo_core/ops/vector.py`	Switch `filter_bbox` to spatial-index queries (but predicate currently inverts intended behavior).
`openeo_core/ops/raster.py`	Use spatial index in `aggregate_spatial`; allow `stack_to_samples` / `unstack_from_samples` to accept multi-dim features.
`openeo_core/model/base.py`	Add `dimension` parameter to model factories; `ml_predict` now derives feature dims from the model; save/load persists dims.
`openeo_core/model/mlm.py`	Add `_feature_dims` field to `MLModel`.
`tests/test_model_torch.py`	Update PyTorch model tests for flattened multi-dimension features and dimension defaults/customization.
`tests/test_model_sklearn.py`	Add tests covering `dimension=["bands","t"]` flattening and default-dimension behavior.
`pyproject.toml`	Add project metadata (keywords/classifiers/URLs) and extras (incl. `ml-torch`, `all`).
`README.md`	Document feature dimensions and add usage/examples + badges.
`.github/workflows/publish.yml`	Add GitHub Actions workflow to build and publish releases to TestPyPI then PyPI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

openeo_core/ops/vector.py

openeo_core/model/base.py

openeo_core/ops/raster.py

Copilot · 2026-03-01T09:49:43Z

@PondiB I've opened a new pull request, #24, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-03-01T09:51:42Z

@PondiB I've opened a new pull request, #25, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-03-01T09:52:07Z

@PondiB I've opened a new pull request, #26, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-03-01T09:52:25Z

@PondiB I've opened a new pull request, #27, to work on those changes. Once the pull request is ready, I'll request review from you.

…tack_from_samples Co-authored-by: PondiB <16879290+PondiB@users.noreply.github.com>

Co-authored-by: PondiB <16879290+PondiB@users.noreply.github.com>

…s" is correct Clarify sindex predicate semantics in filter_bbox; predicate="contains" is correct

…rom_samples Validate non-empty feature_dim list in stack_to_samples and unstack_from_samples

…ict` Fix silent fallback when `_feature_dims` is an empty list in `ml_predict`

Copilot · 2026-03-01T10:48:06Z

@PondiB I've opened a new pull request, #28, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-03-01T10:48:22Z

@PondiB I've opened a new pull request, #29, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: PondiB <16879290+PondiB@users.noreply.github.com>

Validate `dimension` parameter in MLModel factory functions

Remove unused logging import and logger from vector.py

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

openeo_core/ops/vector.py

openeo_core/model/base.py

.github/workflows/publish.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-03-01T11:10:22Z

@PondiB I've opened a new pull request, #30, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-03-01T11:10:48Z

@PondiB I've opened a new pull request, #31, to work on those changes. Once the pull request is ready, I'll request review from you.

…ility Co-authored-by: PondiB <16879290+PondiB@users.noreply.github.com>

Co-authored-by: PondiB <16879290+PondiB@users.noreply.github.com>

…ards compatibility Restore `feature_dim` as a deprecated kwarg on `ml_predict` for backwards compatibility

…is correct Clarify filter_bbox sindex predicate semantics; predicate="contains" is correct

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

openeo_core/model/base.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

spatial index, ml dimensions, publish

dac2570

PondiB requested a review from Copilot February 28, 2026 21:52

Copilot started reviewing on behalf of PondiB February 28, 2026 21:52 View session

Copilot AI reviewed Feb 28, 2026

View reviewed changes

Initial plan

0e2c0bc

Copilot AI mentioned this pull request Mar 1, 2026

Clarify sindex predicate semantics in filter_bbox; predicate="contains" is correct #24

Merged

PondiB and others added 2 commits March 1, 2026 10:50

lazy filter

3a29e7a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

844c2a9

Copilot AI mentioned this pull request Mar 1, 2026

Fix silent fallback when _feature_dims is an empty list in ml_predict #25

Merged

Initial plan

756e84c

Copilot AI mentioned this pull request Mar 1, 2026

Validate non-empty feature_dim list in stack_to_samples and unstack_from_samples #26

Merged

Copilot AI mentioned this pull request Mar 1, 2026

Guard against empty feature_dim list in stack_to_samples and unstack_from_samples #27

Closed

Copilot AI and others added 7 commits March 1, 2026 09:56

Add empty list validation for feature_dim in stack_to_samples and uns…

a391b18

…tack_from_samples Co-authored-by: PondiB <16879290+PondiB@users.noreply.github.com>

Fix _feature_dims empty list handling in ml_predict

f653941

Co-authored-by: PondiB <16879290+PondiB@users.noreply.github.com>

Clarify sindex predicate comment: contains means bbox.contains(geom)

61ece4b

Co-authored-by: PondiB <16879290+PondiB@users.noreply.github.com>

Clarify sindex predicate semantics in filter_bbox; predicate="contain…

12652ca

…s" is correct Clarify sindex predicate semantics in filter_bbox; predicate="contains" is correct

Validate non-empty feature_dim list in stack_to_samples and unstack_f…

f80e5ee

…rom_samples Validate non-empty feature_dim list in stack_to_samples and unstack_from_samples

Fix silent fallback when _feature_dims is an empty list in `ml_pred…

b81b081

…ict` Fix silent fallback when `_feature_dims` is an empty list in `ml_predict`

Initial plan

56b3c71

Copilot AI mentioned this pull request Mar 1, 2026

Validate dimension parameter in MLModel factory functions #28

Merged

Initial plan

2620822

Copilot AI mentioned this pull request Mar 1, 2026

Remove unused logging import and logger from vector.py #29

Merged

Copilot AI and others added 2 commits March 1, 2026 10:48

Remove unused logging import and logger assignment from vector.py

555970f

Co-authored-by: PondiB <16879290+PondiB@users.noreply.github.com>

Remove unused logger assignment from vector.py

5c56231

Co-authored-by: PondiB <16879290+PondiB@users.noreply.github.com>

Copilot AI and others added 3 commits March 1, 2026 10:55

Validate dimension parameter in MLModel factory functions

fb0d4d8

Co-authored-by: PondiB <16879290+PondiB@users.noreply.github.com>

Validate dimension parameter in MLModel factory functions

e177f66

Validate `dimension` parameter in MLModel factory functions

Remove unused logging import and logger from vector.py

e45b76c

Remove unused logging import and logger from vector.py

PondiB requested a review from Copilot March 1, 2026 11:02

Copilot started reviewing on behalf of PondiB March 1, 2026 11:03 View session

Copilot AI reviewed Mar 1, 2026

View reviewed changes

openeo_core/ops/vector.py Show resolved Hide resolved

openeo_core/ops/vector.py Show resolved Hide resolved

openeo_core/model/base.py Show resolved Hide resolved

openeo_core/model/base.py Outdated Show resolved Hide resolved

.github/workflows/publish.yml Outdated Show resolved Hide resolved

PondiB and others added 3 commits March 1, 2026 12:09

pypi skip-existing

e51a6d1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

refactor copy

1301e41

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Initial plan

940f838

Copilot AI mentioned this pull request Mar 1, 2026

Restore feature_dim as a deprecated kwarg on ml_predict for backwards compatibility #30

Merged

Initial plan

27c04e5

Copilot AI mentioned this pull request Mar 1, 2026

Clarify filter_bbox sindex predicate semantics; predicate="contains" is correct #31

Merged

Copilot AI and others added 5 commits March 1, 2026 11:16

Add deprecated feature_dim kwarg to ml_predict for backwards compatib…

6662c95

…ility Co-authored-by: PondiB <16879290+PondiB@users.noreply.github.com>

Clarify sindex predicate comment: contains means bbox.contains(geom)

217a075

Co-authored-by: PondiB <16879290+PondiB@users.noreply.github.com>

Restore feature_dim as a deprecated kwarg on ml_predict for backw…

60d1ba7

…ards compatibility Restore `feature_dim` as a deprecated kwarg on `ml_predict` for backwards compatibility

Clarify filter_bbox sindex predicate semantics; predicate="contains" …

b70e747

…is correct Clarify filter_bbox sindex predicate semantics; predicate="contains" is correct

version 0.1.1

1e51597

PondiB requested a review from Copilot March 2, 2026 07:12

Copilot started reviewing on behalf of PondiB March 2, 2026 07:13 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

openeo_core/model/base.py Outdated Show resolved Hide resolved

checks feat_dims

07cf8a2

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

PondiB merged commit 827c948 into main Mar 2, 2026
30 checks passed

Conversation

PondiB commented Feb 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 1, 2026

Uh oh!

Copilot AI commented Mar 1, 2026

Uh oh!

Copilot AI commented Mar 1, 2026

Uh oh!

Copilot AI commented Mar 1, 2026

Uh oh!

Copilot AI commented Mar 1, 2026

Uh oh!

Copilot AI commented Mar 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 1, 2026

Uh oh!

Copilot AI commented Mar 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants