Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates example workflows and refactors core spatial aggregation and NDVI calculation functions. The changes include a new Python notebook example, updates to three R example files, improvements to geometry handling in aggregate_spatial, and corrections to Sentinel-2 band naming conventions.
Changes:
- Added new Python notebook example (france_example_python.ipynb) demonstrating crop type classification workflow
- Refactored aggregate_spatial function with enhanced geometry repair logic and better handling of invalid geometries and geometry collections
- Updated ndvi function to check target_band parameter first (logically equivalent refactor)
- Added dynamic dx/dy calculation for lat/lon CRS in load_collection
- Corrected Sentinel-2 band naming from single-digit (B8, B9) to two-digit format (B08, B09)
- Translated German messages to English in Session-Class.R
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/09-france/france_example_python.ipynb | New Python notebook demonstrating the openEO workflow for crop classification using Random Forest |
| examples/09-france/france_example_01.R | Updated temporal extent and refactored NDVI/interpolation workflow |
| examples/09-france/france_example_02.R | Updated file paths, CRS, temporal extents, and workflow structure with aggregate_temporal_period |
| examples/09-france/france_example_03.R | Updated file paths, temporal extents, and job execution workflow |
| R/processes-cube.R | Major refactor: enhanced aggregate_spatial geometry repair, added dx/dy calculation for CRS 4326, minor ndvi refactor |
| R/Collection-class.R | Corrected Sentinel-2 band names from B8/B9 to B08/B09 for consistency |
| R/Session-Class.R | Translated German messages to English for better internationalization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: PondiB <16879290+PondiB@users.noreply.github.com>
Co-authored-by: PondiB <16879290+PondiB@users.noreply.github.com>
… aoi_bb_llox to aoi_bbox Co-authored-by: PondiB <16879290+PondiB@users.noreply.github.com>
Fix variable naming inconsistency in france_example_02.R
Fix incorrect assignment operator in function argument
Fix variable naming typos in france_example_02.R
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 9 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
|
|
||
| #' aggregate temporal period | ||
| #' aggregate spatial |
There was a problem hiding this comment.
The comment at line 233 now correctly says "aggregate spatial", but the summary parameter at line 238 still says "Temporal aggregations based on calendar hierarchies" which is incorrect for this spatial aggregation function. The summary should describe spatial aggregations over geometries instead.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.