Skip to content

[FEAT] 홈 화면 배너 에러 해결 #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0Hooni merged 1 commit into from
Oct 19, 2025
Merged

[FEAT] 홈 화면 배너 에러 해결 #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Poppool/PresentationLayer/Presentation/Presentation.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
05125BA12DB6275C001342A2 /* PanModal in Frameworks */ = {isa = PBXBuildFile; productRef = 05125BA02DB6275C001342A2 /* PanModal */; };
051631302DC3D1FD00A6C0D1 /* DesignSystem.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 0516312F2DC3D1FD00A6C0D1 /* DesignSystem.framework */; };
0520B78D2E7410BF009E4BF3 /* RxRelay in Frameworks */ = {isa = PBXBuildFile; productRef = 0520B78C2E7410BF009E4BF3 /* RxRelay */; };
0520C7222E77999F009E4BF3 /* LoginFeatureInterface.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 0520C7212E77999F009E4BF3 /* LoginFeatureInterface.framework */; };
0522C1E12DB67C8300B141FF /* RxSwift in Frameworks */ = {isa = PBXBuildFile; productRef = 0522C1E02DB67C8300B141FF /* RxSwift */; };
055C24D72E28FC6200AD389C /* PresentationInterface.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 05734C352DCDF6EC0093825D /* PresentationInterface.framework */; };
055C24E32E28FCA000AD389C /* DesignSystem.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 0516312F2DC3D1FD00A6C0D1 /* DesignSystem.framework */; };
Expand Down Expand Up @@ -51,6 +52,7 @@

/* Begin PBXFileReference section */
0516312F2DC3D1FD00A6C0D1 /* DesignSystem.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; path = DesignSystem.framework; sourceTree = BUILT_PRODUCTS_DIR; };
0520C7212E77999F009E4BF3 /* LoginFeatureInterface.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; path = LoginFeatureInterface.framework; sourceTree = BUILT_PRODUCTS_DIR; };
055C24D02E28FC3800AD389C /* PresentationTesting.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = PresentationTesting.framework; sourceTree = BUILT_PRODUCTS_DIR; };
05734C352DCDF6EC0093825D /* PresentationInterface.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = PresentationInterface.framework; sourceTree = BUILT_PRODUCTS_DIR; };
05734C402DCDF7190093825D /* SearchFeatureInterface.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; path = SearchFeatureInterface.framework; sourceTree = BUILT_PRODUCTS_DIR; };
Expand Down Expand Up @@ -107,6 +109,7 @@
05C1D62C2DB53A8200508FFD /* DomainInterface.framework in Frameworks */,
05734C3C2DCDF6FE0093825D /* PresentationInterface.framework in Frameworks */,
05125B982DB626E3001342A2 /* ReactorKit in Frameworks */,
0520C7222E77999F009E4BF3 /* LoginFeatureInterface.framework in Frameworks */,
05BDD5CF2DB6770300C1E192 /* Lottie in Frameworks */,
08B2A35B2DB66B5A00E57EFA /* FloatingPanel in Frameworks */,
08B2A3612DB66BAB00E57EFA /* Then in Frameworks */,
Expand Down Expand Up @@ -150,6 +153,7 @@
05C1D6292DB53A8200508FFD /* Frameworks */ = {
isa = PBXGroup;
children = (
0520C7212E77999F009E4BF3 /* LoginFeatureInterface.framework */,
05734C482DCDF7960093825D /* DesignSystem.framework */,
05734C402DCDF7190093825D /* SearchFeatureInterface.framework */,
0516312F2DC3D1FD00A6C0D1 /* DesignSystem.framework */,
Expand Down
29 changes: 19 additions & 10 deletions Poppool/PresentationLayer/Presentation/Presentation/Scene/Home/Main/HomeReactor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,17 +353,26 @@ final class HomeReactor: Reactor {
} else {
switch indexPath.section {
case 0:
if let id = loginImageBannerSection.inputDataList.first?.idList[indexPath.row - 1] {
let controller = DetailController()
controller.reactor = DetailReactor(
popUpID: id,
userAPIUseCase: userAPIUseCase,
popUpAPIUseCase: DIContainer.resolve(PopUpAPIUseCase.self),
commentAPIUseCase: DIContainer.resolve(CommentAPIUseCase.self),
preSignedUseCase: DIContainer.resolve(PreSignedUseCase.self)
)
currentController.navigationController?.pushViewController(controller, animated: true)
if indexPath.row == 0,
let id = loginImageBannerSection.inputDataList.first?.idList[indexPath.row] {
moveToDetail(id: id)
} else if indexPath.row != 0,
let id = loginImageBannerSection.inputDataList.first?.idList[indexPath.row - 1] {
moveToDetail(id: id)
}

func moveToDetail(id: Int64) {
let controller = DetailController()
controller.reactor = DetailReactor(
popUpID: id,
userAPIUseCase: userAPIUseCase,
popUpAPIUseCase: DIContainer.resolve(PopUpAPIUseCase.self),
commentAPIUseCase: DIContainer.resolve(CommentAPIUseCase.self),
preSignedUseCase: DIContainer.resolve(PreSignedUseCase.self)
)
currentController.navigationController?.pushViewController(controller, animated: true)
}

case 2:
let controller = HomeListController()
controller.reactor = HomeListReactor(
Expand Down
12 changes: 7 additions & 5 deletions ...n/Scene/Home/Main/View/ImageBannerSection/ImageBannerSection/ImageBannerSectionCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,13 @@ final class ImageBannerSectionCell: UICollectionViewCell {
playButton.isHidden = true
isAutoBannerPlay = true
autoScrollTimer = Timer.scheduledTimer(withTimeInterval: interval, repeats: true) { [weak self] _ in
guard let self = self else { return }
self.contentCollectionView.scrollToItem(
at: .init(row: self.currentIndex + 1, section: 0),
at: .centeredHorizontally, animated: true
)
guard let self else { return }
if self.contentCollectionView.numberOfItems(inSection: 0) > 1 {
self.contentCollectionView.scrollToItem(
at: .init(row: self.currentIndex + 1, section: 0),
at: .centeredHorizontally, animated: true
)
}
}
}
}
Expand Down