Fixed Function in Templates.php #1123
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
save_buttondefinition in Popup Maker by replacingesc_attr__()withesc_attr_e().esc_attr__()returns the translated string but does not output it directly.esc_attr_e()both translates and immediately echoes the string, which is the expected behavior in this context.Related Issue:
Types of changes
Screenshots
This has been tested in the following browsers
Merge Checklist