Skip to content

Conversation

@DAnn2012
Copy link

Description

This PR updates the save_button definition in Popup Maker by replacing esc_attr__() with esc_attr_e().

  • esc_attr__() returns the translated string but does not output it directly.
  • esc_attr_e() both translates and immediately echoes the string, which is the expected behavior in this context.
  • This ensures that the "Add" label is properly translated and directly rendered in the button output.

Related Issue:

Types of changes

Screenshots

This has been tested in the following browsers

  • Chrome
  • Firefox
  • Edge
  • Safari

Merge Checklist

  • This PR passes all automated checks (will appear once pull request is submitted)
  • My code has been tested in the latest version of WordPress.
  • My code does not have any warnings from ESLint.
  • My code does not have any warnings from StyleLint.
  • My code does not have any warnings from PHPCS.
  • My code follows the WordPress coding standards.
  • My code follows the accessibility standards.
  • All new functions and classes have code documentation.

@coderabbitai
Copy link

coderabbitai bot commented Dec 18, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@DAnn2012
Copy link
Author

Hello @danieliser

When you can, could you take a look at this PR of mine?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant