fix: hide error tracking fingerprint from signal reports#1578
Open
reverb256 wants to merge 3 commits intoPostHog:mainfrom
Open
fix: hide error tracking fingerprint from signal reports#1578reverb256 wants to merge 3 commits intoPostHog:mainfrom
reverb256 wants to merge 3 commits intoPostHog:mainfrom
Conversation
The fingerprint string is very long, not human-readable, and clutters the signal card UI. Removed the fingerprint display block from ErrorTrackingSignalCard. Kept the fingerprint field in the type definition as it's part of the API contract. Fixes PostHog#1573 Signed-off-by: reverb256 <reverb256@users.noreply.github.com>
TypeScript strict mode flags 'extra' as unused since we removed the fingerprint display. Renamed to '_' to indicate intentionally unused. Signed-off-by: reverb256 <reverb256@users.noreply.github.com>
adboio
requested changes
Apr 9, 2026
| function ErrorTrackingSignalCard({ | ||
| signal, | ||
| extra, | ||
| extra: _, |
Contributor
There was a problem hiding this comment.
can we remove this param please if it's now un-used?
Per review feedback, removed the extra parameter entirely instead of renaming to _ since it is no longer used by this component. Signed-off-by: reverb256 <reverb256@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The fingerprint string in error tracking signal cards is very long, not human-readable, and clutters the UI.
Fix
Removed the fingerprint display block (WarningIcon + fingerprint text) from
ErrorTrackingSignalCard. Kept thefingerprintfield in the type definition since it is part of the API contract.Fixes #1573