fix: improve inline code rendering in signal details#1579
Open
reverb256 wants to merge 2 commits intoPostHog:mainfrom
Open
fix: improve inline code rendering in signal details#1579reverb256 wants to merge 2 commits intoPostHog:mainfrom
reverb256 wants to merge 2 commits intoPostHog:mainfrom
Conversation
Inline code (backtick content) in signal cards was barely visible due to ghost variant styling and lack of background. Added explicit CSS for code elements: background, rounded corners, padding, and monospace font to make inline code clearly distinguishable from surrounding text. Fixes PostHog#1567 Signed-off-by: reverb256 <reverb256@users.noreply.github.com>
Two improvements: 1. Preprocess content to unescape double-escaped backticks that might prevent proper markdown parsing 2. Add CSS styling to make inline code more visible with background, padding, and rounded corners This should fix cases where backticks appear as raw text instead of being rendered as inline code. Fixes PostHog#1567 Signed-off-by: reverb256 <reverb256@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Inline code (backtick content) in signal card details is barely visible. The
Codecomponent usesvariant="ghost"which has no background, and the parent container appliescolor: var(--gray-11)which makes inline code blend into surrounding text.Fix
Added explicit CSS rules for
codeelements in the signal card body:bg-gray-4— subtle background to distinguish code from textrounded— rounded cornerspx-1 py-0.5— padding for visual separationfont-mono— explicit monospace fontThis makes inline code clearly distinguishable from surrounding text while maintaining the compact signal card layout.
Fixes #1567