fix: guard against undefined client in useFeatureFlagEnabled #2655
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Additional Comments (2)
-
packages/react/src/hooks/useFeatureFlagEnabled.ts, line 8 (link)logic: Inconsistent null safety - if
clientcan be undefined on line 19, it can also be undefined here whereclient.isFeatureEnabled()is called without optional chaining -
packages/react/src/hooks/useFeatureFlagEnabled.ts, line 11-13 (link)logic: Inconsistent null safety - if
clientcan be undefined on line 19, it can also be undefined here whereclient.onFeatureFlags()andclient.isFeatureEnabled()are called without optional chaining
1 file reviewed, 4 comments
|
|
||
| // if the client is not loaded yet, check if we have a bootstrapped value and then true/false it | ||
| if (!client.featureFlags.hasLoadedFlags && bootstrap?.featureFlags) { | ||
| if (!client?.featureFlags?.hasLoadedFlags && bootstrap?.featureFlags) { |
Contributor
There was a problem hiding this comment.
style: Other similar hooks (useFeatureFlagVariantKey.ts:17, useFeatureFlagPayload.ts:17, useActiveFeatureFlags.ts:16) don't use optional chaining but this one does - consider whether this change is actually needed or if the issue is elsewhere
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/react/src/hooks/useFeatureFlagEnabled.ts
Line: 19:19
Comment:
**style:** Other similar hooks (`useFeatureFlagVariantKey.ts:17`, `useFeatureFlagPayload.ts:17`, `useActiveFeatureFlags.ts:16`) don't use optional chaining but this one does - consider whether this change is actually needed or if the issue is elsewhere
How can I resolve this? If you propose a fix, please make it concise.
Contributor
Contributor
|
Size Change: +1.74 kB (+0.03%) Total Size: 5.08 MB
ℹ️ View Unchanged
|
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
gustavohstrassburger
approved these changes
Dec 2, 2025
gustavohstrassburger
left a comment
gustavohstrassburger
left a comment
There was a problem hiding this comment.
Lets ship it and see if it fixes.
I'm assuming you didn't manage to reproduce it, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The check !client.featureFlags.hasLoadedFlags was causing "cannot read properties of undefined (reading hasLoadedFlags) so changed it to !client?.featureFlags?.hasLoadedFlags
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file