fix: add ruff check to CI and fix all lint errors #360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CI was only running
ruff format --checkbut neverruff check, allowing lint errors to accumulate undetected on master.Problem
The code quality checks in CI only verified formatting:
But never ran linting checks, so errors like unused imports, duplicate function names, and lambda expressions were merging undetected.
Changes
ruff checkstep to CI workflowInconclusiveMatchError as InconclusiveMatchError, etc.)test_openai_reasoning_tokenstotest_openai_reasoning_tokens_o4_miniTesting
Impact
Going forward,
ruff checkwill run in CI and catch lint errors before they merge, maintaining code quality standards.