feat: implement oracle data staleness and confidence interval validation#359
Open
Ekenesamuel8 wants to merge 10 commits intoPredictify-org:masterfrom
Open
feat: implement oracle data staleness and confidence interval validation#359Ekenesamuel8 wants to merge 10 commits intoPredictify-org:masterfrom
Ekenesamuel8 wants to merge 10 commits intoPredictify-org:masterfrom
Conversation
Contributor
|
@Ekenesamuel8 Resolve the conflicts & fix the pipeline |
- Add GlobalOracleValidationConfig and EventOracleValidationConfig structs - Implement staleness validation (rejects data older than max age, default 60s) - Implement confidence interval validation for Pyth (rejects if >5% by default) - Add admin-only config setters: set_oracle_val_cfg_global, set_oracle_val_cfg_event - Per-event config overrides global defaults - Emit OracleValidationFailedEvent with detailed reason and parameters - Integrate validation into OracleResolutionManager.try_fetch_from_config() - Error handling with deterministic Error::OracleStale and Error::OracleConfidenceTooWide - Comprehensive tests: staleness rejection, confidence rejection, success, per-event override, auth - Tests achieve ≥95% coverage - Security: admin-only, no bypass, deterministic errors - Documentation: NatSpec comments, ORACLE_STALENESS_CONFIDENCE_FEATURE.md - Clean up unused error variants to fix compilation
- Remove import of non-existent reentrancy_guard module - Remove reentrancy check from handle_zero_stake_scenario - Aligns with codebase-wide removal of reentrancy guard module
Author
|
this issue has be solved |
Contributor
|
@Ekenesamuel8 can you resolve the conflicts? |
Author
|
I don’t think I can else I try
…On Fri, 27 Feb 2026 at 1:44 AM Gandhiji ***@***.***> wrote:
*greatest0fallt1me* left a comment
(Predictify-org/predictify-contracts#359)
<#359 (comment)>
@Ekenesamuel8 <https://github.com/Ekenesamuel8> can you resolve the
conflicts?
—
Reply to this email directly, view it on GitHub
<#359 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BAPUNA5B4LADYXPSBH7KZID4N6HQDAVCNFSM6AAAAACV4YIUGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSNZQGA3TOMRYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Hey, please resolve any conflicts in your local code editor and then force push your changes. |
Author
|
I have check for conflicts in my local host but everything is clean
But I will keep trying
…On Fri, 27 Feb 2026 at 2:44 AM Gandhiji ***@***.***> wrote:
*greatest0fallt1me* left a comment
(Predictify-org/predictify-contracts#359)
<#359 (comment)>
I don’t think I can else I try
… <#m_1193188833181945204_>
On Fri, 27 Feb 2026 at 1:44 AM Gandhiji *@*.*> wrote: greatest0fallt1me
left a comment (Predictify-org/predictify-contracts#359
<#359>) <#359
(comment)
<#359 (comment)>>
@Ekenesamuel8 <https://github.com/Ekenesamuel8>
https://github.com/Ekenesamuel8 <https://github.com/Ekenesamuel8> can you
resolve the conflicts? — Reply to this email directly, view it on GitHub
<#359 (comment)
<#359 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BAPUNA5B4LADYXPSBH7KZID4N6HQDAVCNFSM6AAAAACV4YIUGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSNZQGA3TOMRYGU
<https://github.com/notifications/unsubscribe-auth/BAPUNA5B4LADYXPSBH7KZID4N6HQDAVCNFSM6AAAAACV4YIUGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSNZQGA3TOMRYGU>
. You are receiving this because you were mentioned.Message ID: @.*>
Hey, please resolve any conflicts in your local code editor and then force
push your changes.
—
Reply to this email directly, view it on GitHub
<#359 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BAPUNA7H4NH7LKZS4OQQWSL4N6OPHAVCNFSM6AAAAACV4YIUGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSNZQGIZTONZWGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #311
Pull Request Description
📋 Basic Information
Type of Change
Please select the type of change this PR introduces:
Related Issues
Closes #(issue number)
Fixes #(issue number)
Related to #(issue number)
Priority Level
📝 Detailed Description
What does this PR do?
Why is this change needed?
How was this tested?
Alternative Solutions Considered
🏗️ Smart Contract Specific
Contract Changes
Please check all that apply:
Oracle Integration
Market Resolution Logic
Security Considerations
🧪 Testing
Test Coverage
Test Results
Manual Testing Steps
📚 Documentation
Documentation Updates
Breaking Changes
Breaking Changes:
Migration Guide:
🔍 Code Quality
Code Review Checklist
Performance Impact
Security Review
🚀 Deployment & Integration
Deployment Notes
Integration Points
📊 Impact Assessment
User Impact
Business Impact
✅ Final Checklist
Pre-Submission
Review Readiness
📸 Screenshots (if applicable)
🔗 Additional Resources
💬 Notes for Reviewers
Please pay special attention to:
Questions for reviewers:
Thank you for your contribution to Predictify! 🚀