-
Notifications
You must be signed in to change notification settings - Fork 28
Remove nix packaging files #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
|
Please see my message in the babble discord as to why i am against removing the entire nix flake, the package part of the nix flake could potentially be removed after this PR in nixpkgs-xr is resolved. As for the nix stuff "breaking" everything for every other distro, this is completely false, this only affects nix users, while the nix flake isnt the core babbles team responsibility to maintain i am willing to maintain it, which is why we are moving to officially package it as part of the NixOS repositories. Just because the package could potentially be removed in the future i do not believe the devshell environment provided by the flake should be removed as i explain in my message on the discord. |
|
|
Sorry, that was an oversight on my part, in this case i should have rather replaced it in the final build instead of removing it from the repo in its entirety. |
We will give you time to make the package available in the Nix package repo, I've already let this PR sit for 2 weeks, but it sounds like you're saying we need to keep certain files in our repo. This will not do, because it puts the burden on me and the core team, and none of us use Nix, nor want to have to maintain code for it, nor take PRs for it when stuff inevitably breaks, and I especially don't want stuff to be broken like it was here because it was only tested on Nix, and no consideration was given to any other distro. Every Nix related file will be removed from our repo. |
|
As i said prior i am more than happy to maintain it, but the devshell part of the flake isnt meant to be used by end users it is purely meant for developers who are using nix to easily set up their own development environment to contribute to the project. the devshell part of the flake does not need extra maintaining and doesnt need to touch the rest of the codebase, there will be no burden on the main babble team as it wont touch the rest of the project. (The changes you quoted prior was for packaging the app for nix, the devshell does not care if any precompiled binaries are present in the source tree only the packaging cared.) As for me saying you need to keep files in the repo this isnt the case, i was just voicing my opinion on removing developer tooling for linux at the end of the day it is up to the babble team on whether or not they want to keep it, it is just my opinion that removing the devshell wouldnt be the best decision as it is purely used for development purposes and is not meant for end users. And it isnt like i have commit access to the repo all changes i have made were reviewed and approved by other members of the team. |
Packaging for NixOS isn't official nor our responsibility. I'm not sure who added it in the first place but whoever put it in this repo made a mistake (and also seemingly broke it for every other distro until I started working on it), doubly so to make it sound official in the readme. This removes the nix related files from our repo.
Resolves #151