modified videodataset for window multiprocessing#8323
Open
JK-rez wants to merge 7 commits intoProject-MONAI:devfrom
Open
modified videodataset for window multiprocessing#8323JK-rez wants to merge 7 commits intoProject-MONAI:devfrom
JK-rez wants to merge 7 commits intoProject-MONAI:devfrom
Conversation
for more information, see https://pre-commit.ci
I, JK-rez <quarezjulien@gmail.com>, hereby add my Signed-off-by to this commit: 068f3be Signed-off-by: JK-rez <quarezjulien@gmail.com>
for more information, see https://pre-commit.ci
Member
|
Thanks for the update. Could we add a test to capture this issue somehow? The problem seems to be multiprocessing in Windows from what we discussed, can we add a unit test using multiprocessing to ensure this works in Windows and elsewhere? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8322
Description
Slight workaround to VideoCapure behaviours when num worker > 0 in dataloader.
Explicitly assign video capture object to release if after reading frame. Should prevent deadlock and other cv2 errors from occurring.
Not tested exhaustively as current pipelines in CV for video pre process videos into frame beforehand. Current dataclass not scalable
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.