Fix flake8 format in PatchEmbeddingBlock#8742
Merged
KumoLiu merged 3 commits intoProject-MONAI:devfrom Feb 15, 2026
Merged
Conversation
Signed-off-by: Yun Liu <yunl@nvidia.com>
Contributor
📝 WalkthroughWalkthroughThree small edits: (1) In monai/networks/blocks/patchembedding.py a dictionary key formatting changed from "p{i+1}" to "p{i + 1}" (whitespace only). (2) In monai/data/box_utils.py non_max_suppression now sorts boxes by score using a stable sort ( Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
/build |
ericspod
approved these changes
Feb 15, 2026
Contributor
Author
|
/build |
Contributor
Author
|
Contributor
Author
|
/build |
1 similar comment
Contributor
Author
|
/build |
Contributor
Author
|
Hi @ericspod blossom works now! You can enable it when you have time. |
Member
Thanks for the effort! That should be done now in the branch rules. |
Rusheel86
pushed a commit
to Rusheel86/MONAI
that referenced
this pull request
Feb 24, 2026
### Description Fix flake8 format in `PatchEmbeddingBlock` ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Yun Liu <yunl@nvidia.com>
Rusheel86
pushed a commit
to Rusheel86/MONAI
that referenced
this pull request
Feb 25, 2026
### Description Fix flake8 format in `PatchEmbeddingBlock` ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Yun Liu <yunl@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix flake8 format in
PatchEmbeddingBlockTypes of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.