Skip to content

Integrate TM Docker plug-in changes to enable passing UID:GID as argu… #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 1, 2023
Merged

Integrate TM Docker plug-in changes to enable passing UID:GID as argu… #149

merged 4 commits into from
Nov 1, 2023

Conversation

@mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Nov 1, 2023 •
edited
Loading

Updates MONAI Deploy Express:

@mocsharp mocsharp requested a review from JHancox November 1, 2023 18:09
@mocsharp mocsharp self-assigned this Nov 1, 2023
@mocsharp mocsharp requested a review from MMelQin November 1, 2023 18:09
@mocsharp mocsharp force-pushed the vchang/liver-tumor-docker-permission branch from f4bd1b6 to 0a929b0 Compare November 1, 2023 18:20
@mocsharp
Integrate TM Docker plug-in changes to enable passing UID:GID as argu…
2e576e6 
…ment.

- add new liver tumor 2.0 sample

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp force-pushed the vchang/liver-tumor-docker-permission branch from 1aa0a3a to 2e576e6 Compare November 1, 2023 18:46
@mocsharp
Pin MinIO image
0b2db7c 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp
Remove continue on error for startup
64cc678 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
MMelQin
MMelQin reviewed Nov 1, 2023
View reviewed changes
@mocsharp
Ue current user ID and group ID
f629aa9 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp requested a review from MMelQin November 1, 2023 20:49
MMelQin
MMelQin reviewed Nov 1, 2023
View reviewed changes
@MMelQin
Copy link
Collaborator

MMelQin commented Nov 1, 2023

Note:
Explicitly specifying the entrypoint/command is only needed for MAP built with earlier version of Packager, namely v0.5.1 and below, because some issues that did not get addressed by the contributor. In v0.6, we have the new internal handler, and do not need to carry on with the workaround. The TM Docker plugin will need to be updated in another PR before we can safely remove the entrypoint/command in the configuration, though.

MMelQin
MMelQin approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@MMelQin MMelQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mocsharp
Copy link
Collaborator Author

mocsharp commented Nov 1, 2023

Test passed on the same Liver Tumor 2.0 container built with user 1000:1000 and ran MDE on a system with a user ID 1001.

@mocsharp mocsharp merged commit f1cf8cd into main Nov 1, 2023
@mocsharp mocsharp deleted the vchang/liver-tumor-docker-permission branch November 1, 2023 21:27
@MMelQin MMelQin linked an issue Nov 10, 2023 that may be closed by this pull request
MAP built with App SDK v0.6 fails when running on MONAI Deploy Express #147
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MMelQin MMelQin MMelQin approved these changes

@JHancox JHancox JHancox approved these changes

Assignees

@mocsharp mocsharp

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MAP built with App SDK v0.6 fails when running on MONAI Deploy Express

4 participants

@mocsharp @MMelQin @JHancox