Split File Output Concurrency Fix #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a class SplitFileWriterManager that wraps the PrintWriters required for the split file output so they can be accessed concurrently and closed once after IBD detection is complete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the split file output by introducing a class that manages the PrintWriters for each proxy key and file type ("IBD" and "HBD"). It includes some suggested changes from a previous review. I tested this branch to confirm that the split files match the output from the single thread run and that using multiple threads decreases the wall runtime.
Some notes:
getWriterForProxyKeydo not close PrintWriters, but there is nothing preventing them from doing so, which would cause problems for other threads trying to write to the same file.