Switch to bc jdk15on dependency to be compatible with WCv2 library. #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkula
approved these changes
Jan 13, 2023
mattkula
left a comment
mattkula
left a comment
There was a problem hiding this comment.
This probably doesn't need any security sign off does it?
Author
|
@matthewrkula I don't think so |
jagtejsodhi
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new WalletConnectV2 library uses
jdk15oninstead ofjdk15to18, which causes duplicate class errors when using both the V2 library and this V1 library together in the same project.The easiest path forward here is to switch this repo to use
jdk15onso that Gradle can resolve any dependency conflicts easier.