Skip to content

Fix NPE caused by casting chainId to Double. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prashanOS merged 1 commit into from
Aug 10, 2022
Merged

Fix NPE caused by casting chainId to Double. #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/main/kotlin/org/walletconnect/types/TypeMapConversion.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ fun Session.SessionParams.intoMap(params: MutableMap<String, Any?> = mutableMapO

fun Map<String, *>.extractSessionParams(): Session.SessionParams {
val approved = this["approved"] as? Boolean ?: throw IllegalArgumentException("approved missing")
val chainId = (this["chainId"] as Double).toLong()
val chainId = (this["chainId"] as? Double)?.toLong()
val accounts = nullOnThrow { (this["accounts"] as? List<*>)?.toStringList() }

return Session.SessionParams(approved, chainId, accounts, nullOnThrow { this.extractPeerData() })
Expand Down