Skip to content

Fix incorrect ion mass in fluxes#5

Merged
bclyons12 merged 1 commit intomasterfrom
bugfix_iona
Nov 13, 2025
Merged

Fix incorrect ion mass in fluxes#5
bclyons12 merged 1 commit intomasterfrom
bugfix_iona

Conversation

@bclyons12
Copy link
Copy Markdown
Collaborator

Seems like a bug that propagated through to IMAS as well, but I don't know if there's some hacky reason were doing this. Can someone please confirm that this fix is correct?

@tomneiser
Copy link
Copy Markdown
Collaborator

tomneiser commented Nov 13, 2025

Maybe this worked because these stand for the atomic number and Z number of the nucleus, which are the same. If a stands for the mass number A then there is a difference

@bclyons12
Copy link
Copy Markdown
Collaborator Author

Yes, a is the mass in IMAS.

@orso82
Copy link
Copy Markdown
Contributor

orso82 commented Nov 13, 2025

this is a bug, should be merged

@bclyons12 bclyons12 merged commit c3acb3e into master Nov 13, 2025
1 check passed
@bclyons12 bclyons12 deleted the bugfix_iona branch November 13, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants