Skip to content

Fix: Missing TransactionIDs issue #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tomiir wants to merge 2 commits into
base: release/0.6.2.1
Choose a base branch
from
Open

Fix: Missing TransactionIDs issue #697

tomiir wants to merge 2 commits into from

Conversation

@tomiir
Copy link
Contributor

@tomiir tomiir commented Dec 4, 2022

Changelog

  • Fixes issue where transaction IDs were being overwritten by other transactions being executed.
  • Made transactionIds persistent and wipe dangling ids in controller instantiation.
  • Refactored transaction storage hooks to make them promises in order to be able to handle them with async/await

Type of changes included:

  • Components
  • Business Logic
  • Bug fixes
  • Styling
  • Code Refactor

Tested on:

  • Chrome
  • Firefox
  • Safari

@rocky-fleek
Removed callbacks from reviewPendingTransaction. Added missing awaits…
0fa9a87 
…. Refactored transactionId hooks to make them promises and handle them with async await. Added clear transactions on controller instantiation. Made transactionIds persistent in storage
@tomiir tomiir changed the base branch from develop to release/0.6.2.1 December 4, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomiir @rocky-fleek